Skip to content

LEC: default on for ORFS test scripts#3917

Merged
maliberty merged 2 commits intoThe-OpenROAD-Project:masterfrom
Pinata-Consulting:lec-default-on-2
Feb 24, 2026
Merged

LEC: default on for ORFS test scripts#3917
maliberty merged 2 commits intoThe-OpenROAD-Project:masterfrom
Pinata-Consulting:lec-default-on-2

Conversation

@oharboe
Copy link
Collaborator

@oharboe oharboe commented Feb 24, 2026

If LEC fails, then the user should report a github issue and go about his business.

If LEC doesn't fail on the final netlist, then other than causing friction during development, LEC during development isn't an issue

If LEC fails, then the user should report a github issue
and go about his business.

If LEC doesn't fail on the final netlist, then other than
causing friction during development, LEC during development
isn't an issue

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@oharboe oharboe requested a review from maliberty February 24, 2026 05:06
@oharboe
Copy link
Collaborator Author

oharboe commented Feb 24, 2026

@maliberty simpler than #3908

@oharboe
Copy link
Collaborator Author

oharboe commented Feb 24, 2026

@vvbandeira @maliberty Surprising... Why is it blocked?

Running pre-commit security hook....


ERROR: File name is blocked: flow/settings.mk

To request an exception please file an issue on GitHub
Error: Process completed with exit code 1.

@oharboe
Copy link
Collaborator Author

oharboe commented Feb 24, 2026

@maliberty please advice on the scan code error. Merge and forget all about it for now?

@maliberty
Copy link
Member

The top of the Makefile needs updating:

# settings.mk is not under source control. Put variables into this
# file to avoid having to adding the to the make command line.
-include settings.mk

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@oharboe oharboe requested a review from maliberty February 24, 2026 20:03
@maliberty maliberty enabled auto-merge February 24, 2026 20:07
@maliberty maliberty merged commit 7421007 into The-OpenROAD-Project:master Feb 24, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants