Inject export dependencies into AnalysisDetailView

[ThalesMMS]

Summary

• inject analysis export and share sheet dependencies into AnalysisDetailView and its callers
• replace report export flow to generate a PDF via AnalysisExportService and present it with ShareSheetPresenter while surfacing errors via notifications
• implement photo library saving with permission handling and user notifications, plus cover export success and failure scenarios with new unit tests

Testing

• xcodebuild test -project Skinia.xcodeproj -scheme Skinia (fails: command not found: xcodebuild)

---

https://chatgpt.com/codex/tasks/task_e_68d1868bae68832ea20a05e5f3c1fa05

[claude]

Code Review for PR #24: Inject export dependencies into AnalysisDetailView

✅ Strengths

• Dependency Injection: Good architectural decision to inject AnalysisExportService and ShareSheetPresenter rather than creating them internally
• Error Handling: Comprehensive error handling with proper localization and user feedback
• Permission Management: Thorough implementation of photo library permissions with iOS 14+ compatibility
• Test Coverage: Added unit tests for the new export functionality in AnalysisDetailViewModelTests

🔍 Issues & Recommendations

1. Code Organization & Separation of Concerns

The AnalysisDetailView has grown significantly with photo library logic (lines 209-303). Consider extracting this into a dedicated service:

// Consider creating PhotoLibrarySaver service
protocol PhotoLibrarySaverProtocol {
    func saveImage(_ image: UIImage) async throws
}

This would improve testability and keep the view focused on presentation logic.

2. Missing Thread Safety Documentation

The saveImageToPhotoLibrary method performs async operations but lacks clear documentation about thread safety:

• Line 283: PHPhotoLibrary.shared().performChanges is async
• Line 286: Dispatching back to main queue

Consider adding documentation or using async/await pattern consistently.

3. Potential Race Condition

In exportReport() (line 184), the notification is shown immediately after presenting the share sheet. If the share sheet presentation fails, users might see a success message prematurely. Consider showing the success notification only after confirmed presentation.

4. Inconsistent Error Messages

• Line 211: Shows generic error for image access
• Line 296: Shows localized error from system
  Consider standardizing error message formatting for better UX.

5. Test Coverage Gaps

While export functionality is tested, the photo library save logic lacks unit tests. Consider:

• Mocking PHPhotoLibrary for permission scenarios
• Testing error cases for photo saving
• Verifying notification display logic

6. Memory Management

Line 210: Capturing image in the permission request closure could potentially retain large UIImage objects. Consider using weak references where appropriate.

🔒 Security Considerations

• ✅ Properly requests photo library permissions before access
• ✅ Uses appropriate permission levels (.addOnly for iOS 14+)
• ✅ No hardcoded credentials or sensitive data exposed

⚡ Performance Considerations

• Image Handling: Large images passed through multiple closures (line 283). Consider implementing image compression or size limits
• Main Thread Usage: Multiple DispatchQueue.main.async calls could be consolidated using @MainActor annotations

🐛 Potential Bugs

1. Missing Null Check: Line 98 - The "Compartilhar" button calls exportReport() directly without checking if analysisExportService is properly initialized
2. Notification Display: The showNotification helper (line 305) uses Task { @MainActor in ... } which might delay notifications unnecessarily

💡 Suggestions

1. Consider using Swift's new async/await APIs consistently instead of mixing with completion handlers
2. Add analytics/telemetry for export success/failure rates
3. Consider adding a loading indicator during photo save operations
4. Document the expected format and size constraints for exported PDFs

✨ Overall Assessment

The PR successfully implements the export functionality with good error handling and user feedback. The main concerns are around code organization and the need for additional test coverage for the photo library functionality. With the suggested improvements, this would be production-ready code.

Recommendation: Approve with minor changes suggested above, particularly extracting the photo library logic into a separate service for better maintainability.