Update setupLocatorSdkConfig request model#262
Merged
Conversation
pbartolome
approved these changes
Mar 27, 2026
atabel
approved these changes
Mar 30, 2026
|
|
||
| export const setupLocatorSdkConfig = ( | ||
| config: LocatorSdkConfig, | ||
| config: Record<string, unknown>, |
Contributor
Author
There was a problem hiding this comment.
We don't want to maintain an object definition here that will change depending on the SDK version. We prefer to just link to the SDK documentation and accept any JSON object.
I changed it to Record<string, unknown>, but if you prefer another generic type, I will change it.
atabel
approved these changes
Mar 30, 2026
CHANGELOG.md
Outdated
Comment on lines
+3
to
+9
| ## v5.1.0 - 2026-03-27 | ||
|
|
||
| - `setupLocatorSdkConfig`: config parameter now accepts a generic object | ||
| (`Record<string, unknown>`) instead of the specific `LocatorSdkConfig` type | ||
| - `getLocatorSdkConfig`: return type now uses `Record<string, unknown> | null` | ||
| instead of `LocatorSdkConfig | null` | ||
|
|
Contributor
There was a problem hiding this comment.
revert this, changelog.md is updated when the version is released, not in the PR
Marcosld
approved these changes
Mar 30, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the model to match the SDK implementation