Corrección del error de accesibilidad - #43
Merged
Merged
Conversation
ismaelperdomorodriguez-practicas
assigned
ismaelperdomorodriguez-practicas and unassigned
ismaelperdomorodriguez-practicas
There was a problem hiding this comment.
Pull request overview
This PR aims to address an accessibility issue related to the off-canvas side menu by ensuring the menu is not rendered when it is marked as hidden (aria-hidden="true").
Changes:
- Updates the side menu markup in
home.xml(button/aside attributes). - Adds CSS to hide
#teidesat-side-menuwhenaria-hidden="true". - Minor formatting-only change in
home.jsnear the menu open logic.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| addons/teidesat_website/views/pages/home.xml | Adjusts side menu / close button attributes related to accessibility and behavior. |
| addons/teidesat_website/static/src/js/home.js | Minor formatting change near openMenu() (no functional intent). |
| addons/teidesat_website/static/src/css/home.css | Hides the side menu via CSS when aria-hidden="true" to address the accessibility issue. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
58
to
+62
| <button class="teidesat-side-menu__close" | ||
| type="button" | ||
| id="teidesat-menu-close" | ||
| aria-label="Cerrar menú"> | ||
| aria-label="Cerrar menú" | ||
| data-bound="true"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corregido error de accesibilidad