29 hacer la pagina accesible - #41
Merged
ismaelperdomorodriguez-practicas merged 2 commits intoJun 9, 2026
Merged
Conversation
alu0101124896
requested review from
a user,
LuisGuez,
Copilot and
ismaelperdomorodriguez-practicas
June 5, 2026 20:02
There was a problem hiding this comment.
Pull request overview
Este PR busca mejorar la accesibilidad de la web (especialmente Home y Nosotros) añadiendo semántica ARIA, mejor soporte de teclado y estilos de foco visibles en el frontend.
Changes:
- Añade mejoras de accesibilidad en templates (labels ARIA, roles/regions, skip link, ajustes de elementos decorativos).
- Actualiza JS para mejorar comportamiento accesible (FAQ con
aria-expanded/hidden, menú lateral coninert). - Incorpora estilos de foco visible y pequeños ajustes de CSS para soporte de teclado.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| addons/teidesat_website/views/pages/nosotros.xml | Introduce skip link y ajustes ARIA/teclado en la página “Nosotros”. |
| addons/teidesat_website/views/pages/home.xml | Añade semántica ARIA (menú, objetivos, FAQ, slider, timeline, etc.) y foco/teclado. |
| addons/teidesat_website/static/src/js/home.js | Sincroniza interacciones (menú, objetivos, FAQ, slider) con estados accesibles. |
| addons/teidesat_website/static/src/css/nosotros.css | Ajustes de estilos y añade bloque de skip link (actualmente no referenciado). |
| addons/teidesat_website/static/src/css/home.css | Estilos de foco visible, skip link global y refactors de formato. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <!-- SKIP LINK --> | ||
| <a href="#main-content" class="teidesat-skip-link">Saltar al contenido principal</a> | ||
|
|
||
| <main id="main-content" tabindex="-1"> |
| </section> | ||
| </section> | ||
|
|
||
| </main> |
| </section> | ||
|
|
||
| <!-- FRASE LATINA --> | ||
| <section class="teidesat-about-quote-band" aria-hidden="true"> |
| </section> | ||
|
|
||
| <!-- FRASE LATINA --> | ||
| <section class="teidesat-about-quote-band teidesat-about-quote-band--soft" aria-hidden="true"> |
| </section> | ||
|
|
||
| <!-- FRASE LATINA --> | ||
| <section class="teidesat-about-quote-band" aria-hidden="true"> |
| </section> | ||
|
|
||
| <!-- NUESTRA HISTORIA --> | ||
| <section class="teidesat-about-section teidesat-about-section--story" aria-labelledby="historia-heading" tabindex="0"> |
Comment on lines
+12
to
+27
| .skip-link { | ||
| position: absolute; | ||
| top: -100%; | ||
| left: 1rem; | ||
| z-index: 9999; | ||
| padding: 0.5rem 1rem; | ||
| background: #000; | ||
| color: #fff; | ||
| font-weight: bold; | ||
| border-radius: 0 0 4px 4px; | ||
| transition: top 0.2s; | ||
| } | ||
|
|
||
| .skip-link:focus { | ||
| top: 0; | ||
| } |
Comment on lines
+171
to
174
| <h2 id="objetivos-title" tabindex="0">Nuestros objetivos</h2> | ||
| <p tabindex="0"> | ||
| Haz clic en cada punto para descubrir los principales objetivos de TEIDESAT. | ||
| </p> |
Comment on lines
+235
to
+245
| function setObjectiveState(target, isActive) { | ||
| const node = system.querySelector( | ||
| `.objective-node[data-target="${target}"]`, | ||
| ); | ||
| const panel = document.querySelector( | ||
| `.objective-panel[data-panel="${target}"]`, | ||
| ); | ||
|
|
||
| if (node) node.classList.toggle("active", isActive); | ||
| if (panel) panel.classList.toggle("active", isActive); | ||
| } |
Comment on lines
+276
to
+280
| if (toggleAllButton && toggleAllButton.dataset.bound !== "true") { | ||
| toggleAllButton.addEventListener("click", function () { | ||
| const openAll = !areAllOpen(); | ||
|
|
||
| node.dataset.bound = "true"; | ||
| nodes.forEach((node) => { |
ismaelperdomorodriguez-practicas
merged commit Jun 9, 2026
ef032ad
into
feature/teidesat-website
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.