Draft: Add config option to allow block animation without shield#31
Draft
lrockreal wants to merge 1 commit intoTeamMidnightDust:multiversionfrom
Draft
Draft: Add config option to allow block animation without shield#31lrockreal wants to merge 1 commit intoTeamMidnightDust:multiversionfrom
lrockreal wants to merge 1 commit intoTeamMidnightDust:multiversionfrom
Conversation
lrockreal
force-pushed
the
feat/block-without-shield
branch
from
cd6a48a to
b6a8576
Compare
lrockreal
commented
Jan 11, 2026
Author
There was a problem hiding this comment.
Will need russian translations for the config option and tooltip
lrockreal
commented
Jan 11, 2026
Author
There was a problem hiding this comment.
Slightly rearranged to avoid repeat computation while adding no-shield logic
lrockreal
force-pushed
the
feat/block-without-shield
branch
from
b6a8576 to
b526141
Compare
lrockreal
force-pushed
the
feat/block-without-shield
branch
from
b526141 to
5f51084
Compare
lrockreal
commented
Jan 11, 2026
Author
There was a problem hiding this comment.
With requireShield disabled, any hand with a sword plays the block animation. May want to turn into another config option.
lrockreal
commented
Jan 11, 2026
Author
|
Change runs deeper than I thought unfortunately. Without a shield in your offhand there is no item to trigger the use action hook. Leaving as a draft in case anyone wants to pick up where I'm leaving off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would close #30
Needs: