Skip to content

_#423

Merged
xtsea merged 2 commits into
betafrom
dev
Sep 10, 2025
Merged

_#423
xtsea merged 2 commits into
betafrom
dev

Conversation

@xtsea

@xtsea xtsea commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Refactor OpenAI image edit call to simplify image encoding and centralize error handling

Enhancements:

  • Inline base64 image encoding call into request payload
  • Remove nested try/except block and consolidate FileNotFoundError/IOError handling into the outer exception clause

@sourcery-ai

sourcery-ai Bot commented Sep 10, 2025

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors image encoding by inlining the Helpers.encode_image_base64 call into the request payload and consolidating file I/O errors into a single outer exception handler for cleaner flow.

Class diagram for updated error handling in image encoding

classDiagram
    class _call_image_openai {
        +__call__(...)
    }
    class Helpers {
        +encode_image_base64(file_path)
    }
    class BadRequestError
    class EmptyResponseError
    class InternalServerError
    class GeneratedImageOrVideo {
        +client
        +content
    }
    _call_image_openai --> Helpers : uses
    _call_image_openai --> BadRequestError : raises
    _call_image_openai --> EmptyResponseError : raises
    _call_image_openai --> InternalServerError : raises
    _call_image_openai --> GeneratedImageOrVideo : returns
Loading

Flow diagram for refactored image encoding and error handling

flowchart TD
    A["Start __call__"] --> B["Prepare request payload"]
    B --> C["Helpers.encode_image_base64(file_path)"]
    C --> D["Send request to OpenAI API"]
    D --> E["Check response"]
    E --> F["Return GeneratedImageOrVideo"]
    C -->|FileNotFoundError/IOError| G["Raise BadRequestError"]
    D -->|Empty response| H["Raise EmptyResponseError"]
    A -->|Other Exception| I["Log error and raise InternalServerError"]
Loading

File-Level Changes

Change Details Files
Inline base64 encoding into JSON payload and consolidate error handling
  • Removed inner try/catch around Helpers.encode_image_base64
  • Inlined Helpers.encode_image_base64 call directly in the request json
  • Added outer except for FileNotFoundError and IOError to raise BadRequestError
  • Dropped redundant generic encoding exception handling
Ryzenth/_callbody/_call_image_openai.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@xtsea xtsea merged commit 6500bad into beta Sep 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant