Updated documentation and fixed issues #4 and #5.

[c0dist]

No description provided.

[anantshri]

one bug identified.

$pwd
/home/android/
$apk2java /home/android/Desktop/TRY\ ME/crackme-three.apk ./"TEST ME"

expectation: a folder @ "/home/android/TEST ME"
but "/home/android/Desktop/TRY\ ME/TEST ME" is created
so spaces are handled nicely which is the core issue with #5
but the CWD somewhere is lost in relative paths.

May be using realpath could be a solution

[anantshri]

this is where we need to see if the $2 is relative or full path and then append the full path. may be realpath or grealpath (in case of mac) in this case would be helpful.

[c0dist]

@anantshri I have (hopefully) fixed the bug mentioned here. For testing, I mimicked following scenarios:

Either the source or destination could be in current path, an absolute path or a relative path. Below are the situations and output:

Note: For the tests, assume working directory as: /home/android/Desktop/apk2java

1. APK in absolute path — Destination is current

$ ./apk2java /tmp/com.domobile.applockwatcher.apk
APK_DIR_PATH: /tmp
Source dir: /home/android/Desktop/apk2java/com.domobile.applockwatcher.apk_src/

2. APK in absolute path — Destination is relative

$ ./apk2java /tmp/com.domobile.applockwatcher.apk "./test"
APK_DIR_PATH: /tmp
Source dir: /home/android/Desktop/apk2java/./test/com.domobile.applockwatcher.apk_src/

3. APK is in absolute path — Destination is absolute path:

$ apk2java /tmp/com.domobile.applockwatcher.apk /tmp/testcase/
APK_DIR_PATH: /tmp
Source dir: /tmp/testcase//com.domobile.applockwatcher.apk_src/

4. APK path is relative — Destination is absolute

$ apk2java ../apks/com.domobile.applockwatcher.apk /tmp/testcase/
APK_DIR_PATH: /home/android/Desktop/apks
Source dir: /tmp/testcase//com.domobile.applockwatcher.apk_src/

5. APK path is relative — Destination is relative

$ apk2java ../apks/com.domobile.applockwatcher.apk ../../Desktop
APK_DIR_PATH: /home/android/Desktop/apks
Source dir: /home/android/Desktop/apk2java/../../Desktop/com.domobile.applockwatcher.apk_src/

6. APK path is relative — Destination is current/no dest

$ apk2java ../apks/com.domobile.applockwatcher.apk
APK_DIR_PATH: /home/android/Desktop/apks
Source dir: /home/android/Desktop/apk2java/com.domobile.applockwatcher.apk_src/

7. APK is in current dir — Destination is absolute

$ apk2java com.domobile.applockwatcher.apk /tmp/testcase/
APK_DIR_PATH: /home/android/Desktop/apk2java
Source dir: /tmp/testcase//com.domobile.applockwatcher.apk_src/

8. APK is in current dir — Destination is relative

$ apk2java com.domobile.applockwatcher.apk ../../Desktop
APK_DIR_PATH: /home/android/Desktop/apk2java
Source dir: /home/android/Desktop/apk2java/../../Desktop/com.domobile.applockwatcher.apk_src/

9. APK is in current dir — Destination not given/current one

$ apk2java com.domobile.applockwatcher.apk
APK_DIR_PATH: /home/android/Desktop/apk2java
Source dir: /home/android/Desktop/apk2java/com.domobile.applockwatcher.apk_src/

Let me know if this works for you.

[roblav96]

@anantshri @c0dist Why hasn't this been merged? :X

[anantshri]

@roblav96 Thanks for the reminder. This completely skipped my radar. I will be looking at in next 2-3 days and will get this added in.

[roblav96]

@anantshri Such a useful tool! :D Thank you!