Migrate base interfaces to statistical_comparison_core and statistica… - #38
Open
HarukiNishimura-TRI wants to merge 5 commits into
Open
Migrate base interfaces to statistical_comparison_core and statistica…#38HarukiNishimura-TRI wants to merge 5 commits into
HarukiNishimura-TRI wants to merge 5 commits into
Conversation
…l_comparison_helpers - Replace base.py with re-export shim from statistical_comparison_core (preserves object identity for all shared interfaces) - Add statistical-comparison-core and statistical-comparison-helpers to install_requires - Add deprecation shim tests (test_sbt_deprecation_shims.py) - Update tools/plotting.py deprecation shims; plots and CLD are now implemented in statistical-comparison-helpers - setup.py updated with the correct license and a new version tag
There was a problem hiding this comment.
Pull request overview
Migrates shared hypothesis-test interfaces and plotting/CLD utilities out of sequentialized_barnard_tests into the new statistical_comparison_core / statistical_comparison_helpers packages, while keeping backwards compatibility via re-export and deprecation shims.
Changes:
- Replaces
sequentialized_barnard_tests.baseimplementations with a re-export shim fromstatistical_comparison_core.base. - Converts plotting/CLD utilities in
sequentialized_barnard_tests.tools.plottinginto deprecation shims delegating tostatistical_comparison_helpers. - Updates packaging metadata/dependencies and adds tests to validate deprecation shims.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
sequentialized_barnard_tests/base.py |
Re-exports shared base interfaces from statistical_comparison_core to preserve import compatibility. |
sequentialized_barnard_tests/tools/plotting.py |
Replaces local implementations with deprecation shims delegating to statistical_comparison_helpers. |
tests/sequentialized_barnard_tests/test_sbt_deprecation_shims.py |
Adds tests to validate deprecation warnings and shim output parity. |
setup.py |
Bumps version, updates license string, and adds new external package dependencies. |
Comments suppressed due to low confidence (1)
sequentialized_barnard_tests/tools/plotting.py:8
- After refactoring these functions into deprecation shims,
get_cmapandstatsare no longer referenced in this module. Keeping unused imports can break linting/static checks and makes the module harder to maintain.
from matplotlib.cm import get_cmap
import matplotlib.pyplot as plt
import numpy as np
from scipy import stats
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate base interfaces to statistical_comparison_core and statistical_comparison_helpers
This closes #37