Skip to content

Migrate base interfaces to statistical_comparison_core and statistica… - #38

Open
HarukiNishimura-TRI wants to merge 5 commits into
mainfrom
dependency_cleanup
Open

Migrate base interfaces to statistical_comparison_core and statistica…#38
HarukiNishimura-TRI wants to merge 5 commits into
mainfrom
dependency_cleanup

Conversation

@HarukiNishimura-TRI

Copy link
Copy Markdown
Collaborator

Migrate base interfaces to statistical_comparison_core and statistical_comparison_helpers

  • Replace base.py with re-export shim from statistical_comparison_core (preserves object identity for all shared interfaces)
  • Add statistical-comparison-core and statistical-comparison-helpers to install_requires
  • Add deprecation shim tests (test_sbt_deprecation_shims.py)
  • Update tools/plotting.py deprecation shims; plots and CLD are now implemented in statistical-comparison-helpers
  • setup.py updated with the correct license and a new version tag

This closes #37

…l_comparison_helpers

- Replace base.py with re-export shim from statistical_comparison_core
  (preserves object identity for all shared interfaces)
- Add statistical-comparison-core and statistical-comparison-helpers to install_requires
- Add deprecation shim tests (test_sbt_deprecation_shims.py)
- Update tools/plotting.py deprecation shims; plots and CLD are now implemented in
  statistical-comparison-helpers
- setup.py updated with the correct license and a new version tag

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates shared hypothesis-test interfaces and plotting/CLD utilities out of sequentialized_barnard_tests into the new statistical_comparison_core / statistical_comparison_helpers packages, while keeping backwards compatibility via re-export and deprecation shims.

Changes:

  • Replaces sequentialized_barnard_tests.base implementations with a re-export shim from statistical_comparison_core.base.
  • Converts plotting/CLD utilities in sequentialized_barnard_tests.tools.plotting into deprecation shims delegating to statistical_comparison_helpers.
  • Updates packaging metadata/dependencies and adds tests to validate deprecation shims.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
sequentialized_barnard_tests/base.py Re-exports shared base interfaces from statistical_comparison_core to preserve import compatibility.
sequentialized_barnard_tests/tools/plotting.py Replaces local implementations with deprecation shims delegating to statistical_comparison_helpers.
tests/sequentialized_barnard_tests/test_sbt_deprecation_shims.py Adds tests to validate deprecation warnings and shim output parity.
setup.py Bumps version, updates license string, and adds new external package dependencies.
Comments suppressed due to low confidence (1)

sequentialized_barnard_tests/tools/plotting.py:8

  • After refactoring these functions into deprecation shims, get_cmap and stats are no longer referenced in this module. Keeping unused imports can break linting/static checks and makes the module harder to maintain.
from matplotlib.cm import get_cmap
import matplotlib.pyplot as plt
import numpy as np
from scipy import stats

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/sequentialized_barnard_tests/test_sbt_deprecation_shims.py Outdated
Comment thread setup.py Outdated
Comment thread tests/sequentialized_barnard_tests/test_sbt_deprecation_shims.py
Comment thread tests/sequentialized_barnard_tests/test_sbt_deprecation_shims.py Outdated
HarukiNishimura-TRI and others added 4 commits July 2, 2026 18:02
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate shared statistical test interfaces and plotting tools to separate packages.

2 participants