Release 0.8.3 follow-up: bump in-bundle VERSION constants - #108
Merged
Conversation
The 0.8.3 PR bumped package.json but missed the two hardcoded VERSION constants, so a published 0.8.3 would have reported itself as 0.8.2. `SDK.tsx`'s copy is the one that matters operationally: it's passed to sdkAxiosMaker and lands on every backend request, surfacing as the `version` field on PolicyHolderSDKView log lines. That field is how we fingerprint which customer is on which SDK build -- and with four customers needing to pick up the DOB fix, shipping a 0.8.3 that reports 0.8.2 would have left us unable to tell who had upgraded. `sdk-core.tsx`'s copy only feeds the console banner. Both are hand-maintained duplicates of package.json's version, which is how they got missed. Worth deriving them from package.json at build time so a future release can't drift the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #107, which must not ship without this.
#107 bumped
package.jsonto 0.8.3 but left the two hardcodedVERSIONconstants at0.8.2, so the published bundle would have reported itself as the previous version.assets/sdk/components/SDK.tsx:44— passed tosdkAxiosMakerand sent on every backend request; this is theversionfield on server-side SDK log lines.assets/sdk/entries/sdk-core.tsx:12— console banner only.The first is the operationally important one. It's how we identify which customer is running which SDK build, and 0.8.3 is a fix four customers need to pick up — shipping a build that reports 0.8.2 would have made the rollout impossible to verify.
Caught during release prep by grepping the built bundle for the version string instead of trusting
package.json.Both constants are hand-maintained duplicates of
package.json'sversion, which is why they drifted. Deriving them at build time (webpackDefinePlugin) would prevent a recurrence; left out here to keep the release moving.Dev PR: LakeEriePartners/stream-connect-js-sdk#9.
npm test(biome + tsc) passes.