Created unit test that currently fails.#714
Open
Conversation
Once the feature works, the matching process should be considerably faster and this test should succeed.
Not sure whether this will actually fly, because the matching process should not be dependent on the ordering of the triple patterns in the graph pattern and I am not sure whether this match flag is possible without doing exactly that.
Collaborator
Author
|
Ran into an issue where depending on the order in which the triple patterns of a graph pattern are processed, different combi matches are produced. This should, of course, not happen, (i.e. the same graph patterns should always produce the same matches) so we have to see if we can find an improvement that does not have this unwanted property. |
…mbinatory-explosion-but-also-prevents-combining-data-from-different-kbs-with-the-same-graph-pattern
Also, a few unit tests fail, which probably need to remove the matchflag to function.
However, I cannot find good logic to prevent the extra matches from being found. Also, depending on the ordering of the graph pattern it still returns different matches for the same graph pattern, I think. It does, however, increase the performance significantly by reducing the number of matches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once the feature works, the matching process should be considerably faster and this test should succeed.