tests: pass when missing torch#1400
Merged
Merged
Conversation
KrisThielemans
approved these changes
May 12, 2026
casperdcl
added a commit
to SyneRBI/SIRF-SuperBuild
that referenced
this pull request
May 12, 2026
paskino
requested changes
May 13, 2026
Contributor
There was a problem hiding this comment.
Currently the reason why the SB failed was that torch wasn't installed on the CI so pytest didn't run any test; careful developers decided that in this situation you should fail catastrofically, but without a reasonable error message.
We haven't understood the reason of the SB failure for a while, despite the hints in the coverage warning message.
Therefore, I would add this test to the test_torch.py with appropriate message regarding whether torch is installed or not.
Member
Author
|
Best to just keep the dummy test in a separate file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows e.g. SuperBuild
ctestto pass without installingtorch.