Open
Conversation
glitteringkatie
commented
Apr 12, 2021
| .then(data => data.toString()); | ||
|
|
||
| const mdxParse = (str) => | ||
| mdx(str, { |
Author
There was a problem hiding this comment.
I was debating between using a unified pipeline or mdx itself and decided on mdx itself because the output ended up being more of what I expected (like jsx and correct html nodes as opposed to literal braces and unknown nodes becoming <div>s).
And then since I used mdx here, I kept it consistent with the example in the documentation.
glitteringkatie
commented
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using
remark-deflistwith MDX and started to get some errors (namely thatmdxSpanExpressiondidn't exist!). I saw in the docs for mdast-util-mdx-jsx that the key to fixing it was some options.In sleuthing this out, I saw that there were two other issues that I think would be fixed by contributing this back!
I debated between just adding these mdx settings directly or passing them as options to remark-deflist. I decided upon utilizing options (and adding some docs on what options to pass in) for the sake of flexibility.
Quick note: I had prettier turned on and it got aggressive. Let me know if you want to try the changes again without the prettier changes but I think consistent syntax isn't bad 🤷. The main difference within
packages/remark-deflist/src/index.jsis the passing around of options.toMarkdownOptions and options.fromMarkdownOptions.