Vanilla crafting, item drops and Ravengard dialogue colours - #883
Merged
Conversation
Dropped items ignored vanilla entirely: throws left the player at five times the intended speed with an invented upward boost, spawned a block above the feet rather than below eye level, became collectable after half a second instead of two, and vanished after a minute rather than five. Block breaks reused the same throw. This adds a reusable drop system carrying vanilla's throw and block pop maths, pickup delays, despawn timing and stack merging, and routes skyblock's throws, block breaks, mob loot and pet abilities through it while keeping drops owner locked and invisible to everyone else. The entity also counts its own age from construction because minestom starts counting at spawn, which happens only after the chunk loads, so a delay could elapse before the item existed.
The grid was left to minestom's default inventory handling and only observed afterwards through a scheduled slot watcher, so dragging was rejected outright, shift clicking out of the grid landed items in hotbar slot eight because minestom scans the hotbar backwards, the result could stay stale after a right shift click, shift crafting counted free space in total rather than per slot and could consume ingredients for output it could not place, and every render resent the window packet and killed any drag in progress. Click resolution, the grid model and the recipe lookup are now separate layers with vanilla's own fill orders, all three drag modes, a take only result slot and shaped recipes matched mirrored as vanilla does.
The speaker colour was opened on an empty component and never reached the name appended after it, so ravengard npcs spoke with white names while their nameplates stayed pink. The lobby command also treated ravengard as its own lobby family, so it returned players to the ravengard lobby instead of the prototype lobby that hub already covers.
Swofty-Developments
force-pushed
the
feat/vanilla-crafting-and-drops
branch
from
August 15, 2026 02:29
254385f to
381ed36
Compare
Swofty-Developments
marked this pull request as ready for review
August 15, 2026 02:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.