Updating Streamline branch

[Dreamersoul]

No description provided.

[Maryom]

Salaam,

Great job :) Just a small note, in app_template.swift I think it's important to add author, current date, and current year :

//
//  {{ app.name }}.swift
//  Appz
//
//  Created by {{ author.name }} on {{currentDate}}.
//  Copyright © {{currentYear}} kitz. All rights reserved.
//

Does anyone agree?

[Mazyod]

The files don't really have an author, so it's better be kept as is. Sure, the current_year would be a nice thing.

[Mazyod]

Everything looks great! I just have one small observation in the actions method, especially since it's quite long.

[Mazyod]

I am not exactly sure why you aren't using templates here? I think it's much cleaner if you create smaller template files, like action_template.txt or something.

[Dreamersoul]

I am planning on refactoring this code since it's really looking awful, your suggestion is way better than what I had in mind, gonna work on it next time I can.

[Dreamersoul]

the actions are now being generated using a jinja template, should be way better now.

[Mazyod]

@Dreamersoul Definitely starting to look a lot more organized.

I also imagined that every part would be a template, and then we can have a template loader globally, TemplateLoader.get("blah"). Something like parameter_enum_template.txt, parameter_arg_template.txt, action_enum_template.txt, action_definition_template.txt, ... etc. This will make sure the script doesn't deal with any string manipulation, and trust Jinja for all that stuff.

This might be just a burden, so I leave it up to you whether it is worth it or not.

[Dreamersoul]

I love how this is going, I'll try to make it work after writing tests.

[Maryom]

If you don't mind I have a question what about using Swift script as mentioned here

And as mentioned:
"Even if this isn’t the exact solution for the exact problem that you’re trying to solve, the concepts that we will go over here will be applicable to other Swift scripts that you might want to write."

I think it will be easier in testing.

[Mazyod]

@Maryom What is your question?

[Mazyod]

@Maryom It is up to the contributor to decide which language he prefers. It almost makes no difference what language is used for the script, as long as it provides the functionality we require and is widely available on most machines.

[Maryom]

@Mazyod You are right but I liked their way that why I shared it here. Do you think their way will be easier in testing? I think so ..

[Mazyod]

@Maryom Why do you think it's easier to test? I'm sure it's harder. Testing in python is so easy, you literally do it like this using py.test:

class AppzTests:
  def test_1_plus_1():
    assert 1 + 1 == 2

[Dreamersoul]

consider using the join method like here instead of appending and removing the trailing ","

", ".join(["hello", "world", "last string"])
# 'hello, world, last string'