Open
Conversation
* in residual, assume "isat2" in x is at STC, ie "isat2_t0" and calculate isat2 using `diode.isat_t()` * also fix all documentation in gen_coeffs to render okay * make example a callable script, allow user to specify whether they want to fit just STC or all IEC61853, show generated coeffs, and save figure * futurize Bennet's module mismatch simulator for py36 * add contrib, gen_coeffs, and module mismatch simulator to docs in new api section called contrib * add example output figures * fix intersphinx, must use https, leave off trailing slash * don't ignore git conflict files, so they can be removed without hiding * ignore the new .pytest_cache folder, move python3 __pycache__ folder to #build * fix underline in README.rst, should be as long as the title
in RMSE relative to STC
* also change some lingering RSH to RSH_E0, in test_diode import * update documentation in gen_coeffs to add effective irradiance, ee * make chart in example change depending on ISC0 and VOC0 * update contrib tiled reference module for python3, Isat2 fix, and Rsh * expand abbreviations in docstrings in pvcell, say Rsh_E0 is at reference irradiance * use Rsh_E0 in vdiode_norm, characteristic diode voltage * update tests for Rsh irradiance dependence to pass
Contributor
|
Hi @mikofski,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #74