[modularization] Pull google analytics & bugsnag into frogpond/analytics#2901
Merged
Conversation
hawkrives
changed the title
rye
previously approved these changes
Aug 26, 2018
drewvolz
previously approved these changes
Aug 26, 2018
|
Danger run resulted in 1 warning and 1 schedule; to find out more, see the checks page. Generated by 🚫 dangerJS |
rye
force-pushed
the
reorg-take6-part5.18
branch
from
be2e80d to
512385b
Compare
Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com> Tested-by: Kristofer Rye <kristofer.rye@gmail.com>
Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com> Tested-by: Kristofer Rye <kristofer.rye@gmail.com>
rye
approved these changes
Aug 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I pulled Google Analytics and Bugsnag into a new module,
@frogpond/analytics. I also re-exported the functions that we use, so as to hopefully make it easier to switch out the underlying providers.I also pulled reportNetworkProblem into
@frogpond/analytics.Part of the great #1537 redo.