[modularization] Move the lib/api function into frogpond/api#2899
Merged
Conversation
rye
previously approved these changes
Aug 26, 2018
drewvolz
previously approved these changes
Aug 26, 2018
Member
Author
|
Needs #2898, at least, I think |
rye
force-pushed
the
reorg-take6-part5.16
branch
from
dc13afe to
e23ea35
Compare
rye
approved these changes
Aug 27, 2018
rye
left a comment
rye
left a comment
Member
There was a problem hiding this comment.
I was able to cleanly rebase this onto master. Flow runs fine locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the "frogpond api" file into a module,
@frogpond/api.This is the
import {API} from …thing that I introduced for talking with ccc-server.This PR also introduces a
setApiRootfunction, to be called as part of app initialization before theAPIfunction is ever called. This should allow the module to be agnostic between CARLS and AllAboutOlaf.Part of the great #1537 redo.