Skip to content

Set up library to allow importing from @app / @frogpond in a monorepo#2881

Merged
hawkrives merged 3 commits into
masterfrom
reorg-take6-part4
Aug 25, 2018
Merged

Set up library to allow importing from @app / @frogpond in a monorepo#2881
hawkrives merged 3 commits into
masterfrom
reorg-take6-part4

Conversation

@hawkrives

@hawkrives hawkrives commented Aug 25, 2018

Copy link
Copy Markdown
Member

There are no real changes to the code base here.


So! This is part of a refurbished, repolished #1537 (the giant reorganization PR). That one tried to do three separate things (move components/ to the top level, reorganize app initialization, and restructure the app views); I've decided to break the changes into smaller chunks for review 😸

This PR sets up the infrastructure to allow us to do import * as c from '@app/components/colors' instead of import * as c from '../../../../../components/colors', in both Flow and Babel.

Code movements are coming up next.

Timeline

  • Move components to source/
  • Rename flux/ to redux/
  • Reorganize app initialization
  • Set up things to we can do import … from '@app/components/colors' instead of import … from '../../../../components/colors'
  • Extract reusable views from views/ into modules/
  • Automate-ish the loading of views from views/ and deprecate the views.js object

@hawkrives hawkrives self-assigned this Aug 25, 2018
@hawkrives hawkrives requested review from a team, drewvolz and rye August 25, 2018 22:48
@hawkrives hawkrives merged commit 50e76f0 into master Aug 25, 2018
@hawkrives hawkrives deleted the reorg-take6-part4 branch August 26, 2018 00:25
@rye rye added this to the v2.6 milestone Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants