Skip to content

Reorganize app initialization files#2880

Merged
hawkrives merged 4 commits into
masterfrom
reorg-take6-part3
Aug 25, 2018
Merged

Reorganize app initialization files#2880
hawkrives merged 4 commits into
masterfrom
reorg-take6-part3

Conversation

@hawkrives

@hawkrives hawkrives commented Aug 25, 2018

Copy link
Copy Markdown
Member

I'll update all of this later, but this one reorganizes the init stage of the app and the associated folders.

Out and about on my phone at the moment, but I wanted to open this.

There are many more changes here.


So! This is part of a refurbished, repolished #1537 (the giant reorganization PR). That one tried to do three separate things (move components/ to the top level, reorganize app initialization, and restructure the app views); I've decided to break the changes into smaller chunks for review 😸

This PR is the first of the actual code change PRs; it reorganizes the /source/*.js files that just kinda got stuck in at random times.

  • Move the /source/*.js files, except for app and root, into /source/init/
  • Rename globals to constants
  • Split the navigation imports and navigator creation into two files
  • Move trackScreenChanges into a separate file
  • Split analytics initialization out of the analytics tracking file
  • Centralize IS_PRODUCTION constant into constants.js
  • Move things out of /source/init that aren't part of initialization into /source/lib
  • Alphabetize the list of Navigation imports

Some of this stuff will move around more in the future, too, but I'm moving them here as well in the interest of smaller PRs.

Timeline

  • Move components to source/
  • Rename flux/ to redux/
  • Reorganize app initialization
  • Set up things to we can do import … from '@app/components/colors' instead of import … from '../../../../components/colors'
  • Extract reusable views from views/ into modules/
  • Automate-ish the loading of views from views/ and deprecate the views.js object

@hawkrives hawkrives self-assigned this Aug 25, 2018
@hawkrives hawkrives requested a review from a team August 25, 2018 22:28
@hawkrives hawkrives changed the title Reorg take6 part3 Reorganize app initialization files Aug 25, 2018
@hawkrives hawkrives merged commit 057ecd6 into master Aug 25, 2018
@hawkrives hawkrives deleted the reorg-take6-part3 branch August 26, 2018 00:25
@rye rye added this to the v2.6 milestone Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants