Reorganize app initialization files#2880
Merged
Merged
Conversation
- move navigation stuff to its own folder - move API to its own file - make more use of constants.js
rye
approved these changes
Aug 25, 2018
drewvolz
approved these changes
Aug 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll update all of this later, but this one reorganizes the init stage of the app and the associated folders.Out and about on my phone at the moment, but I wanted to open this.There are many more changes here.
So! This is part of a refurbished, repolished #1537 (the giant reorganization PR). That one tried to do three separate things (move
components/ to the top level, reorganize app initialization, and restructure the app views); I've decided to break the changes into smaller chunks for review 😸This PR is the first of the actual code change PRs; it reorganizes the
/source/*.jsfiles that just kinda got stuck in at random times./source/*.jsfiles, except for app and root, into/source/init/globalstoconstantstrackScreenChangesinto a separate fileIS_PRODUCTIONconstant intoconstants.js/source/initthat aren't part of initialization into/source/libSome of this stuff will move around more in the future, too, but I'm moving them here as well in the interest of smaller PRs.
Timeline
source/flux/toredux/import … from '@app/components/colors'instead ofimport … from '../../../../components/colors'views/intomodules/views/and deprecate theviews.jsobject