Skip to content

Move /source/views/components to /source/components#2877

Merged
hawkrives merged 3 commits into
masterfrom
reorg-take6-part1
Aug 25, 2018
Merged

Move /source/views/components to /source/components#2877
hawkrives merged 3 commits into
masterfrom
reorg-take6-part1

Conversation

@hawkrives

@hawkrives hawkrives commented Aug 25, 2018

Copy link
Copy Markdown
Member

There are a lot of changes here, but they're all of this form:

- import type {NavType} from '../../types'
+ import type {NavType} from '../../views/types'

So! This is part of a refurbished, repolished #1537 (the giant reorganization PR). That one tried to do three separate things (move components/ to the top level, reorganize app initialization, and restructure the app views); I've decided to break the changes into smaller chunks for review 😸

This PR just moves the components/ folder to the top of source/ (this will make more sense once I move things out of views/, which will happen. Maybe even today.).

Flow doesn't complain about these changes, and the app still builds in manual testing.

Timeline

  • Move components to source/
  • Rename flux/ to redux/
  • Reorganize app initialization
  • Set up things to we can do import … from '@app/components/colors' instead of import … from '../../../../components/colors'
  • Extract reusable views from views/ into modules/
  • Automate-ish the loading of views from views/ and deprecate the views.js object

@hawkrives hawkrives requested a review from a team August 25, 2018 18:01
@hawkrives

Copy link
Copy Markdown
Member Author

I think Circle's having issues:

image is cached as circleci/node:8, but refreshing...

  Error pulling image circleci/node:8: Error response from daemon: received unexpected HTTP status: 503 Service Unavailable... retrying
  image is cached as circleci/node:8, but refreshing…

@rye

rye commented Aug 25, 2018

Copy link
Copy Markdown
Member

Due to an upstream Docker Hub planned maintenance interval: https://success.docker.com/article/planned-downtime-on-hub-cloud-store

@hawkrives

Copy link
Copy Markdown
Member Author

wonderful

Guess I'll just get some more branches ready then

@hawkrives hawkrives merged commit ed331b9 into master Aug 25, 2018
@hawkrives hawkrives changed the title Move a /source/views/components to /source/components Move /source/views/components to /source/components Aug 25, 2018
@hawkrives hawkrives deleted the reorg-take6-part1 branch August 26, 2018 00:25
@rye rye added this to the v2.6 milestone Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants