Move /source/views/components to /source/components#2877
Merged
Conversation
Member
Author
|
I think Circle's having issues: |
Member
|
Due to an upstream Docker Hub planned maintenance interval: https://success.docker.com/article/planned-downtime-on-hub-cloud-store |
Member
Author
|
wonderful Guess I'll just get some more branches ready then |
rye
approved these changes
Aug 25, 2018
drewvolz
approved these changes
Aug 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a lot of changes here, but they're all of this form:
So! This is part of a refurbished, repolished #1537 (the giant reorganization PR). That one tried to do three separate things (move
components/ to the top level, reorganize app initialization, and restructure the app views); I've decided to break the changes into smaller chunks for review 😸This PR just moves the
components/folder to the top ofsource/(this will make more sense once I move things out ofviews/, which will happen. Maybe even today.).Flow doesn't complain about these changes, and the app still builds in manual testing.
Timeline
source/flux/toredux/import … from '@app/components/colors'instead ofimport … from '../../../../components/colors'views/intomodules/views/and deprecate theviews.jsobject