BMR-1768: Resolve getRectForRef crash on popover unmount#200
Open
ramruizni57blocks wants to merge 5 commits intoSteffeyDev:masterfrom
Open
BMR-1768: Resolve getRectForRef crash on popover unmount#200ramruizni57blocks wants to merge 5 commits intoSteffeyDev:masterfrom
ramruizni57blocks wants to merge 5 commits intoSteffeyDev:masterfrom
Conversation
fix: remove background element from screen reader focus in popovers
Collaborator
|
You seem to have added a whole dist folder which doesn't make sense. Remove them so it's easier to see what you actually changed in the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves unhandled promise rejection when a popover's parent unmounts while calculateRectFromRef is polling — getRectForRef now resolves with a zero Rect instead of rejecting when ref.current is null