Skip to content

Housekeeping#532

Merged
trulyno merged 28 commits into
mainfrom
housekeeping
Jun 10, 2026
Merged

Housekeeping#532
trulyno merged 28 commits into
mainfrom
housekeeping

Conversation

@trulyno

@trulyno trulyno commented May 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Change compile workflow to trigger only on push to main/develop and on PRs with build label
  • Add navigation documentation in kubejs codebase (markdown files)
  • Delete branch on merge
  • Prettier check workflow
  • Update compile data
  • Cleanup .gitignore
  • Add helper scripts
  • Configure Prettier/ESLint
  • Remove packmodes
  • Code cleanup
  • Remake README.md

@trulyno trulyno added the build Triggers the compile workflow in PRs label May 31, 2026
lstanden
lstanden reviewed Jun 1, 2026
View reviewed changes
Comment thread .github/workflows/delete-branch.yml Outdated
@trulyno trulyno removed the build Triggers the compile workflow in PRs label Jun 5, 2026
github-actions[bot]
github-actions Bot requested changes Jun 5, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KubeJS Scripts Lint & Format Review

Found 0 formatting issue(s) and 741 lint issue(s).

Prettier suggestions can be committed directly from this review.
Run npm run format:fix && npm run lint:fix locally to fix everything at once.

Comment thread kubejs/client_scripts/ponder/multis.js
Comment thread kubejs/client_scripts/ponder/multis.js
Comment thread kubejs/client_scripts/ponder/multis.js Outdated
Comment thread kubejs/client_scripts/ponder/multis.js Outdated
Comment thread kubejs/client_scripts/ponder/multis.js Outdated
Comment thread kubejs/client_scripts/ponder/scenes/classic_stargate.js
Comment thread kubejs/client_scripts/ponder/scenes/classic_stargate.js
Comment thread kubejs/client_scripts/ponder/scenes/classic_stargate.js
Comment thread kubejs/client_scripts/ponder/scenes/classic_stargate.js
Comment thread kubejs/client_scripts/ponder/scenes/classic_stargate.js
github-actions[bot]
github-actions Bot requested changes Jun 5, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KubeJS Scripts Lint & Format Review

Found 0 formatting issue(s) and 741 lint issue(s).

Showing first 20 inline comment(s) — 721 additional issue(s) not shown.
Prettier suggestions can be committed directly from this review.
Run npm run format:fix && npm run lint:fix locally to fix everything at once.

Comment thread kubejs/client_scripts/ponder/multis.js
Comment thread kubejs/client_scripts/ponder/multis.js
Comment thread kubejs/client_scripts/ponder/multis.js Outdated
Comment thread kubejs/client_scripts/ponder/multis.js Outdated
Comment thread kubejs/client_scripts/ponder/multis.js Outdated
Comment thread kubejs/client_scripts/ponder/multis.js
Comment thread kubejs/client_scripts/ponder/multis.js
Comment thread kubejs/client_scripts/ponder/multis.js
Comment thread kubejs/client_scripts/ponder/multis.js Outdated
Comment thread kubejs/client_scripts/ponder/multis.js Outdated
github-actions[bot]
github-actions Bot previously requested changes Jun 5, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KubeJS Scripts Lint & Format Review

Found 0 formatting issue(s) and 523 lint issue(s).

Showing first 20 inline comment(s) — 503 additional issue(s) not shown.
Prettier suggestions can be committed directly from this review.
Run npm run format:fix && npm run lint:fix locally to fix everything at once.

Comment thread kubejs/client_scripts/ponder/scenes/classic_stargate.js
Comment thread kubejs/client_scripts/ponder/utils.js
Comment thread kubejs/client_scripts/ponder/utils.js Outdated
Comment thread kubejs/client_scripts/ponder/utils.js
Comment thread kubejs/client_scripts/ponder/utils.js
Comment thread kubejs/client_scripts/ponder/utils.js Outdated
Comment thread kubejs/client_scripts/ponder/utils.js Outdated
Comment thread kubejs/client_scripts/ponder/utils.js Outdated
Comment thread kubejs/client_scripts/ponder/utils.js Outdated
Comment thread kubejs/client_scripts/ponder/utils.js Outdated
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

✅ KubeJS Scripts Lint & Format Review

All scripts pass formatting and lint checks. Nice work!

@trulyno trulyno added the build Triggers the compile workflow in PRs label Jun 8, 2026
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

✅ KubeJS Scripts Lint & Format Review

All scripts pass formatting and lint checks. Nice work!

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

✅ KubeJS Scripts Lint & Format Review

All scripts pass formatting and lint checks. Nice work!

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

✅ KubeJS Scripts Lint & Format Review

All scripts pass formatting and lint checks. Nice work!

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

✅ KubeJS Scripts Lint & Format Review

All scripts pass formatting and lint checks. Nice work!

@trulyno trulyno marked this pull request as ready for review June 10, 2026 08:44
@trulyno

trulyno commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Housekeeping is done and ready for review!
Adding helper scripts and readme/pack desc will be done in separate prs

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

✅ KubeJS Scripts Lint & Format Review

All scripts pass formatting and lint checks. Nice work!

LuziferSenpai
LuziferSenpai approved these changes Jun 10, 2026
View reviewed changes

@LuziferSenpai LuziferSenpai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

UltraPuPower
UltraPuPower approved these changes Jun 10, 2026
View reviewed changes

@UltraPuPower UltraPuPower left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I looked through it all, can't see any glaring issues

@trulyno trulyno merged commit a252783 into main Jun 10, 2026
2 checks passed
@trulyno trulyno deleted the housekeeping branch June 10, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LuziferSenpai LuziferSenpai LuziferSenpai approved these changes

@UltraPuPower UltraPuPower UltraPuPower approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

+1 more reviewer

@lstanden lstanden lstanden left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Triggers the compile workflow in PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trulyno @lstanden @LuziferSenpai @UltraPuPower