Ensure compute unit locations respects order of unit ids #4329
+19
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishalcrow
added
bug
for more information, see https://pre-commit.ci
yger
reviewed
Jan 20, 2026
| unit_ids = sorting_analyzer_or_templates.unit_ids | ||
| else: | ||
| unit_ids = np.asanyarray(unit_ids) | ||
| keep = np.isin(sorting_analyzer_or_templates.unit_ids, unit_ids) |
Collaborator
There was a problem hiding this comment.
I would prefer a syntax with units_to_indices(unit_ids), but maybe this would require to implement such a function for the Templates
alejoe91
reviewed
Jan 20, 2026
| unit_ids = np.asanyarray(unit_ids) | ||
| keep = np.isin(sorting_analyzer_or_templates.unit_ids, unit_ids) | ||
| templates = templates[keep, :, :] | ||
| keep = [np.where(sorting_analyzer_or_templates.unit_ids == unit_id)[0][0] for unit_id in unit_ids] |
Member
There was a problem hiding this comment.
Suggested change
| keep = [np.where(sorting_analyzer_or_templates.unit_ids == unit_id)[0][0] for unit_id in unit_ids] | |
| unit_ids = list(sorting_analyzer_or_templates.unit_ids) | |
| keep_unit_indices = np.array([unit_ids.index(unit_id) for unit_id in unit_ids]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4328
To compute unit locations, you need to loop over templates. This PR ensures that the templates are ordered in the same way as the user-inputted unit ids if they are given.
Added a test to the common_extension_tests, but it only applies to extensions which allow for the user to input
unit_ids. Turns out: this is just unit locations. I still think it's a new place to put the test?