fix: ordering hallucinations and per milestone contributors ordering - #362
Merged
Conversation
|
Looks like you did not link an issue to this PR. If this PR completes a task, consider linking it. |
There was a problem hiding this comment.
Pull request overview
This PR addresses inconsistent (“hallucinated”) ordering in resource lists by ensuring list data is refreshed after reorder mutations and by preventing sorting/filtering UI from interfering with orderable resources. It also updates React Query and adjusts QueryClient initialization for SSR.
Changes:
- Add
onSuccesssupport to the order mutation hook and invalidate the list query after successful reorders. - Disable sort/filter definitions + UI for orderable resources to avoid conflicting ordering behavior.
- Update
@tanstack/react-queryto^5.101.0, adjust QueryClient lifecycle, and clear query cache on logout.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/features/abstract-resource-list/hooks/use-order-mutation.ts | Adds onSuccess option forwarding to the mutation wrapper. |
| src/features/abstract-resource-list/components/infinite-scroller.tsx | Introduces a shared queryKey and invalidates it after successful reorder. |
| src/features/abstract-resource-list/components/abstract-resource-list.tsx | Skips sort/filter setup + UI for orderable resources. |
| src/features/abstract-resource-form/components/arf-relation-input.tsx | Prevents orderable handling for many-to-many relations. |
| src/components/providers/root-providers.tsx | Refactors QueryClient creation for SSR/client, but uses a non-public React Query API. |
| src/components/presentation/logout-button.tsx | Clears React Query cache on logout during navigation. |
| package.json | Bumps @tanstack/react-query dependency version. |
| package-lock.json | Updates lockfile for new TanStack Query versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
michalges
force-pushed
the
fix/ordering-hallucinations
branch
from
July 13, 2026 15:20
82f9535 to
dd94b78
Compare
michalges
commented
Jul 13, 2026
michalges
force-pushed
the
fix/ordering-hallucinations
branch
from
July 19, 2026 11:47
dd94b78 to
37b7e5f
Compare
michalges
changed the title
GTR1701
approved these changes
Jul 20, 2026
GTR1701
left a comment
GTR1701
left a comment
Member
There was a problem hiding this comment.
Wydaje się być git. Tam w query cliencie tylko jest przerzucone do funkcji a tak to działa tak samo z tego co widzę.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ogólnie z jakiegoś powodu dało się sortować orderable resource'y (co trochę nie ma sensu - bo co niby działo się gdy zmieniało się sortowanie i wtedy przeciągało kolejność xD), stąd te niektóre zmiany w tym do testów
Na przyszłość można pomyśleć jak ten pivot ordering jakoś lepiej zintegrować z typami resourców, na razie to jest tak żeby było