fix(arc): date parsing in date picker hotfix - #322
Merged
Conversation
|
Looks like you did not link an issue to this PR. If this PR completes a task, consider linking it. |
There was a problem hiding this comment.
Pull request overview
Hotfix to prevent the ARC date picker from breaking when it receives an unparsable date string, ensuring the UI safely treats invalid values as empty.
Changes:
- Add
date-fns/isValidguard so invalid parsed dates becomenullinDatePicker. - Minor refactor/rename of
getRoundedDateparameter and signature formatting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/components/inputs/date-picker.tsx | Guards against invalid parsed dates to avoid formatting/selection errors. |
| src/utils/get-rounded-date.ts | Renames the hours parameter and tightens the function signature formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kguzek
approved these changes
Mar 25, 2026
kguzek
force-pushed
the
fix/date-picker-hotfix
branch
from
March 25, 2026 23:22
1510dac to
f60d8da
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 500 error in
/versions/createand possibly other routes