Skip to content

feat(resources): add item descriptors - #285

Merged
kguzek merged 2 commits into
mainfrom
feat/item-descriptors
Mar 7, 2026
Merged

feat(resources): add item descriptors#285
kguzek merged 2 commits into
mainfrom
feat/item-descriptors

Conversation

@kguzek

@kguzek kguzek commented Mar 7, 2026

Copy link
Copy Markdown
Member

resolves #283

@kguzek kguzek self-assigned this Mar 7, 2026
Copilot AI review requested due to automatic review settings March 7, 2026 18:36
@kguzek kguzek added the enhancement New feature or request label Mar 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates resource list display to support an optional “descriptor” alongside an item’s primary name, and uses it to remove specialName from Building select-option labels while still showing it in the resource list UI (resolves #283).

Changes:

  • Add descriptor?: string | null to ListItem for displaying secondary text next to the name in the resource list.
  • Update Buildings metadata mapping so name is only identifier, and specialName is moved into descriptor.
  • Update ArlItem rendering to show descriptor in italics next to name when present.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/features/resources/data/resource-metadata.ts Adjusts Buildings itemMapper to separate identifier (name) from specialName (descriptor), keeping selects clean.
src/features/abstract-resource-list/types/internal.ts Extends ListItem type with the new descriptor field and documents intended UI usage.
src/features/abstract-resource-list/components/arl-item.tsx Renders descriptor next to name in the resource list item UI when non-empty.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/features/abstract-resource-list/components/arl-item.tsx
@pull-request-size pull-request-size Bot added size/M and removed size/S labels Mar 7, 2026
@kguzek
kguzek merged commit d2bf19d into main Mar 7, 2026
8 checks passed
@kguzek
kguzek deleted the feat/item-descriptors branch March 7, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

usunąć wartość specialName z pól wyboru budynków

2 participants