Skip to content

feat(grave): implement grave details provider and integrate with bottom sheet UI - #18

Closed
katherinabozhok-hub wants to merge 2 commits into
mainfrom
Kasia_Provider_branch
Closed

feat(grave): implement grave details provider and integrate with bottom sheet UI#18
katherinabozhok-hub wants to merge 2 commits into
mainfrom
Kasia_Provider_branch

Conversation

@katherinabozhok-hub

Copy link
Copy Markdown
Collaborator

No description provided.

@MarmoPL MarmoPL left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now this is all i found
please remove generated files and format

Dio dio(Ref ref) {
final dio = Dio(
BaseOptions(
baseUrl: 'https://api.grobownik.topwr.solvro.pl/v1',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now it's okay, but we're gonna change it to be in env file

@override
void didAddProvider(ProviderObserverContext context, Object? value) {
if (!kDebugMode) return;
debugPrint('--- [Riverpod Added] ---');

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug prints not needed

import 'dart:async';
import 'package:riverpod_annotation/riverpod_annotation.dart';

// Импортируем модель Grave через package-путь

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without comments please

Comment thread lib/widgets/bottom_sheet.dart Outdated
}

void _collapse() => _animateSheet(sheet.snapSizes!.first);
void _collapse() => _animateSheet(0.05); // подправь если у тебя тут snapSizes

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Comment thread lib/widgets/bottom_sheet.dart Outdated
snapSizes: const [0.05, 0.5, 0.95],
controller: _controller,
builder: (context, scrollController) {
return Card(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you removed DefaultTabController?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants