fix(das): specify foreign key for timetable entry - #327
Merged
Conversation
Contributor
|
Looks like you did not link an issue to this PR. If this PR completes a task, consider linking it. |
mini-bomba
approved these changes
Jul 16, 2026
mini-bomba
left a comment
mini-bomba
left a comment
Member
There was a problem hiding this comment.
, but i'd rather you didn't generate pr descriptions with ai
mini-bomba
added a commit
that referenced
this pull request
Jul 16, 2026
This makes sure issues like #327 are detected in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes preloading timetable entries through the DAS timetable endpoint.
Lucid inferred the relation foreign key as
dasTimetableId, whileDasTimetableEntrydefines it astimetableId. This caused requests with theentriesrelation to fail withE_MISSING_MODEL_ATTRIBUTE.The relation now explicitly uses
timetableId.Before
Returned HTTP 500:
Relation "DasTimetable.entries" expects "dasTimetableId" to exist on
"DasTimetableEntry" model, but is missing.
failling prod endpoint: https://api.topwr.solvro.pl/api/v1/das_timetables/1?entries=true
After
The same request returns HTTP 200 with the timetable entries preloaded,
including entries with a nullable endTime.