Skip to content

WIP: fix: show orphaned student tasks#520

Draft
nbey wants to merge 3 commits into
developfrom
fix/student-tasks-grouping
Draft

WIP: fix: show orphaned student tasks#520
nbey wants to merge 3 commits into
developfrom
fix/student-tasks-grouping

Conversation

@nbey

@nbey nbey commented Mar 19, 2020

Copy link
Copy Markdown
Contributor

This PR aims to resolve an issue where student tasks that have a parent task that is not currently being included in the tasks store are not being shown.

  • show orphaned student tasks
  • sort tasks by due date, title ascending (client-side)
  • redundant server-side sort
  • create cypress test case

- improve nomenclature
Comment thread sencha-workspace/SlateTasksStudent/app/view/TaskTree.js Outdated
@nbey nbey changed the title fix: show orphaned student tasks WIP: fix: show orphaned student tasks Mar 24, 2020
@themightychris

Copy link
Copy Markdown
Contributor

@nbey ping me on slack when this is ready for final review/merge

@themightychris

themightychris commented Apr 21, 2020

Copy link
Copy Markdown
Contributor

@nbey did we merge this in another PR already?

@nbey

nbey commented Apr 26, 2020

Copy link
Copy Markdown
Contributor Author

Nope -- I ran into some issues with getting the server-side sorting to fall-back and replicate the front-end. Also, I think I still need to create a cypress test case for this.

@themightychris themightychris marked this pull request as draft December 8, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants