Skip to content

fix(fixtures): fail loud on non-ENOENT readdir errors in the conformance runner #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SingleSourceStudios merged 1 commit into from
May 26, 2026
Merged

fix(fixtures): fail loud on non-ENOENT readdir errors in the conformance runner #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions spec/fixtures/run-fixtures.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,16 @@ function runCategory(category) {
files = readdirSync(dir)
.filter((f) => f.endsWith(".logic.md"))
.sort();
} catch {
console.log(`\n⚠ Skipping ${category}/ (directory not found)`);
return;
} catch (err) {
if (err.code === "ENOENT") {
console.log(`\n⚠ Skipping ${category}/ (directory not found)`);
return;
}
// Any other error (EACCES, ENOTDIR, EIO, EMFILE, ...) means the runner
// could not read a category it was meant to read. Fail loud with a
// distinct exit code so partial success is never reported as full success.
console.error(`\n✗ Failed to read ${category}/: ${err.message}`);
process.exit(2);
}

console.log(`\n${category}/`);
Expand Down