build: Enable exactOptionalPropertyTypes#175
Closed
SimonAlling wants to merge 3 commits into
Closed
Conversation
SimonAlling
added a commit
that referenced
this pull request
May 11, 2025
I'm considering introducing [Semantic Versioning for TypeScript Types][semver-ts], which requires `exactOptionalPropertyTypes` (and `noUncheckedIndexedAccess`, which was enabled in #174). Without `skipLibCheck`, we get this compilation error: node_modules/@types/webpack/index.d.ts:2264:23 - error TS2430: Interface 'Options' incorrectly extends interface 'MinifyOptions'. Types of property 'sourceMap' are incompatible. Type 'boolean | undefined' is not assignable to type 'boolean | SourceMapOptions'. Type 'undefined' is not assignable to type 'boolean | SourceMapOptions'. 2264 interface Options extends UglifyJS.MinifyOptions { ~~~~~~~ Maybe we can disable `skipLibCheck` again in the future, but for now it has to go. [semver-ts]: https://www.semver-ts.org/#for-package-authors
Owner
Author
|
Uh, it was merged in 18def6e. 😵💫 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm considering introducing Semantic Versioning for TypeScript Types, which requires
exactOptionalPropertyTypes(andnoUncheckedIndexedAccess, which was enabled in #174).Without
skipLibCheck, we get this compilation error:Maybe we can disable
skipLibCheckagain in the future, but for now it has to go.