Time varying resistance coronary boundary condition#214
Merged
ncdorn merged 13 commits intoSimVascular:masterfrom Feb 26, 2026
Merged
Time varying resistance coronary boundary condition#214ncdorn merged 13 commits intoSimVascular:masterfrom
ncdorn merged 13 commits intoSimVascular:masterfrom
Conversation
# Conflicts: # docs/references.bib # src/model/BlockType.h # src/model/OpenLoopCoronaryBC.h # tests/test_solver.py
ncdorn
approved these changes
Feb 26, 2026
Contributor
|
nice work, thanks martin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current situation
Closes #208
Release Notes
Add a time-varying resistance coronary boundary condition (inherits form current coronary BC)
Documentation
Added doxygen and description in test case.
Testing
Added test case, plotted results compared to constant resistance BC, made sense
Code of Conduct & Contributing Guidelines