Skip to content

fix: add acquisition_software_name/version fields for openmassspec-core 1.4.0 - #33

Merged
Nathan-D-R merged 1 commit into
mainfrom
fix/core-1-4-0-run-metadata
Jul 29, 2026
Merged

fix: add acquisition_software_name/version fields for openmassspec-core 1.4.0#33
Nathan-D-R merged 1 commit into
mainfrom
fix/core-1-4-0-run-metadata

Conversation

@Nathan-D-R

Copy link
Copy Markdown
Contributor

Summary

  • Bumps openmassspec-core from 1.3.0 to 1.4.0 in Cargo.toml (and Cargo.lock).
  • Adapts to RunMetadata's two new fields (acquisition_software_name, acquisition_software_version, both Option<String>, no Default impl) at the sole production construction site, run_metadata_for in crates/opentimstdf/src/mzml.rs.
  • Wired a real value rather than the minimal None, None: Reader::metadata already parses AcquisitionSoftware/AcquisitionSoftwareVersion out of analysis.tdf's GlobalMetadata table into this crate's own Metadata::acquisition_software/acquisition_software_version (String, defaulting to empty when the key is absent). run_metadata_for now maps those through, treating an empty string as None rather than surfacing Some("").
  • Added two unit tests: one confirming the real values flow through (run_metadata_for_wires_up_acquisition_software), one confirming empty-string-as-absent maps to None (run_metadata_for_acquisition_software_none_when_empty).
  • Note on the issue's line numbers: by the time this was picked up, the file had already grown past the #31-cited line numbers (658/672), and a re-grep for RunMetadata { turned up only the one production literal - no separate test-only RunMetadata literals exist anymore. Tests build the crate's own Metadata and go through run_metadata_for, so they pick up the new fields automatically.
  • Added a CHANGELOG.md entry under ## [Unreleased].
  • cargo fmt --all, cargo clippy --all-targets -- -D warnings, and cargo test --all all pass clean.

Closes #31

Test plan

  • cargo fmt --all (no diff)
  • cargo clippy --all-targets -- -D warnings (clean)
  • cargo test --all (39/39 passing, including 2 new tests)

…re 1.4.0

Bumps openmassspec-core to 1.4.0, which adds RunMetadata::acquisition_software_name
and acquisition_software_version (both Option<String>, no Default impl). Wires
real values into run_metadata_for from Metadata::acquisition_software /
acquisition_software_version, already parsed from the AcquisitionSoftware /
AcquisitionSoftwareVersion rows in analysis.tdf's GlobalMetadata table by
Reader::metadata - an empty string (the default when the key is absent) maps
to None rather than Some("").

Closes #31.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 29, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
opentimstdf-docs 43c448c Jul 29 2026, 12:21 AM

@Nathan-D-R
Nathan-D-R merged commit 58f674b into main Jul 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add acquisition_software_name/version fields once openmassspec-core hits 1.4.0

1 participant