fix: add acquisition_software_name/version fields for openmassspec-core 1.4.0 - #33
Merged
Merged
Conversation
…re 1.4.0
Bumps openmassspec-core to 1.4.0, which adds RunMetadata::acquisition_software_name
and acquisition_software_version (both Option<String>, no Default impl). Wires
real values into run_metadata_for from Metadata::acquisition_software /
acquisition_software_version, already parsed from the AcquisitionSoftware /
AcquisitionSoftwareVersion rows in analysis.tdf's GlobalMetadata table by
Reader::metadata - an empty string (the default when the key is absent) maps
to None rather than Some("").
Closes #31.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
opentimstdf-docs | 43c448c | Jul 29 2026, 12:21 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openmassspec-corefrom 1.3.0 to 1.4.0 inCargo.toml(andCargo.lock).RunMetadata's two new fields (acquisition_software_name,acquisition_software_version, bothOption<String>, noDefaultimpl) at the sole production construction site,run_metadata_forincrates/opentimstdf/src/mzml.rs.None, None:Reader::metadataalready parsesAcquisitionSoftware/AcquisitionSoftwareVersionout ofanalysis.tdf'sGlobalMetadatatable into this crate's ownMetadata::acquisition_software/acquisition_software_version(String, defaulting to empty when the key is absent).run_metadata_fornow maps those through, treating an empty string asNonerather than surfacingSome("").run_metadata_for_wires_up_acquisition_software), one confirming empty-string-as-absent maps toNone(run_metadata_for_acquisition_software_none_when_empty).#31-cited line numbers (658/672), and a re-grep forRunMetadata {turned up only the one production literal - no separate test-onlyRunMetadataliterals exist anymore. Tests build the crate's ownMetadataand go throughrun_metadata_for, so they pick up the new fields automatically.CHANGELOG.mdentry under## [Unreleased].cargo fmt --all,cargo clippy --all-targets -- -D warnings, andcargo test --allall pass clean.Closes #31
Test plan
cargo fmt --all(no diff)cargo clippy --all-targets -- -D warnings(clean)cargo test --all(39/39 passing, including 2 new tests)