Add warning when using walletd Ledger on non localhost address#1493
Add warning when using walletd Ledger on non localhost address#1493chris124567 wants to merge 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
Pull request overview
Adds a clearer, context-specific warning for Ledger connection attempts when the app is not running in a secure context, addressing walletd issue #391.
Changes:
- Update the “no supported transports” error to show a secure-context (HTTPS/localhost) warning when appropriate.
- Preserve the existing generic “unsupported browser” message for other cases.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexfreska
left a comment
There was a problem hiding this comment.
Looks good! The walletd cluster tests are failing due to the following:
# go.sia.tech/web/cluster/cmd/clusterd
Error: cmd/clusterd/contract.go:346:71: not enough arguments in call to proto4.RenewContract
have ("go.sia.tech/core/types".V2FileContract, "go.sia.tech/core/rhp/v4".HostPrices, "go.sia.tech/core/rhp/v4".RPCRenewContractParams)
want ("go.sia.tech/core/types".V2FileContract, "go.sia.tech/core/rhp/v4".HostPrices, "go.sia.tech/core/types".Address, "go.sia.tech/core/rhp/v4".RPCRenewContractParams)
BUILD FAILED
@chris124567 could you fix that?
alexfreska
left a comment
There was a problem hiding this comment.
@chris124567 could you update commit to follow conventional commit format, this repo has a lint rule.
cd75f7f to
dd70f86
Compare
|
Pushed my commit to fix clusterd but looks like Chris already did it 😄 |
27c51a3 to
dd70f86
Compare
Close SiaFoundation/walletd#391