Skip to content

Add warning when using walletd Ledger on non localhost address#1493

Open
chris124567 wants to merge 2 commits intomainfrom
christopher/walletd-warning
Open

Add warning when using walletd Ledger on non localhost address#1493
chris124567 wants to merge 2 commits intomainfrom
christopher/walletd-warning

Conversation

@chris124567
Copy link
Copy Markdown
Member

Copilot AI review requested due to automatic review settings April 24, 2026 19:06
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 24, 2026

⚠️ No Changeset found

Latest commit: 5474f31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

5 Skipped Deployments
Project Deployment Actions Updated (UTC)
explorer Ignored Ignored Preview Apr 28, 2026 1:04pm
explorer-zen Ignored Ignored Preview Apr 28, 2026 1:04pm
hostd Ignored Ignored Preview Apr 28, 2026 1:04pm
indexd Ignored Ignored Preview Apr 28, 2026 1:04pm
renterd Ignored Ignored Preview Apr 28, 2026 1:04pm

Request Review

@chris124567 chris124567 changed the title Add warning when using walletd on non localhost Add warning when using walletd on non localhost address Apr 24, 2026
@github-project-automation github-project-automation Bot moved this to In Progress in Sia Apr 24, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a clearer, context-specific warning for Ledger connection attempts when the app is not running in a secure context, addressing walletd issue #391.

Changes:

  • Update the “no supported transports” error to show a secure-context (HTTPS/localhost) warning when appropriate.
  • Preserve the existing generic “unsupported browser” message for other cases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/walletd/dialogs/DeviceConnectForm/index.tsx
Comment thread apps/walletd/dialogs/DeviceConnectForm/index.tsx
Comment thread apps/walletd/dialogs/DeviceConnectForm/index.tsx
@chris124567 chris124567 changed the title Add warning when using walletd on non localhost address Add warning when using walletd Ledger on non localhost address Apr 24, 2026
Copy link
Copy Markdown
Member

@alexfreska alexfreska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The walletd cluster tests are failing due to the following:

# go.sia.tech/web/cluster/cmd/clusterd
Error: cmd/clusterd/contract.go:346:71: not enough arguments in call to proto4.RenewContract
	have ("go.sia.tech/core/types".V2FileContract, "go.sia.tech/core/rhp/v4".HostPrices, "go.sia.tech/core/rhp/v4".RPCRenewContractParams)
	want ("go.sia.tech/core/types".V2FileContract, "go.sia.tech/core/rhp/v4".HostPrices, "go.sia.tech/core/types".Address, "go.sia.tech/core/rhp/v4".RPCRenewContractParams)
BUILD FAILED

@chris124567 could you fix that?

Copy link
Copy Markdown
Member

@alexfreska alexfreska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chris124567 could you update commit to follow conventional commit format, this repo has a lint rule.

@chris124567 chris124567 force-pushed the christopher/walletd-warning branch from cd75f7f to dd70f86 Compare April 28, 2026 12:45
@chris124567
Copy link
Copy Markdown
Member Author

Pushed my commit to fix clusterd but looks like Chris already did it 😄

@chris124567 chris124567 force-pushed the christopher/walletd-warning branch from 27c51a3 to dd70f86 Compare April 28, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Unable to connect to Ledger

4 participants