ci: pin GitHub Actions to SHA-256 commits#962
Merged
Merged
Conversation
Pin all action references to specific commit SHAs to prevent supply-chain attacks. Each pin is annotated with a human-readable version tag for clarity. Versions stay within the existing major version to avoid breaking changes.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| jobs: | ||
| test: | ||
| uses: SiaFoundation/workflows/.github/workflows/go-test.yml@master | ||
| uses: SiaFoundation/workflows/.github/workflows/go-test.yml@22e56c0750c0febb09784caa01c60021e0b5f111 # master |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens GitHub Actions workflows by replacing mutable uses: refs with specific commit refs while preserving the previously referenced branches/tags in comments.
Changes:
- Pins reusable SiaFoundation workflows/actions from
masterto a commit SHA. - Pins
actions/checkoutandknope-dev/actionin the release-preparation workflow. - Adds trailing comments documenting the original branch/tag refs.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ui.yml |
Pins the UI update action ref. |
.github/workflows/publish.yml |
Pins the reusable publish workflow ref. |
.github/workflows/project-add.yml |
Pins the project-add reusable workflow ref. |
.github/workflows/prepare-release.yml |
Pins checkout and Knope action refs. |
.github/workflows/openapi-sync.yml |
Pins the OpenAPI sync reusable workflow ref. |
.github/workflows/main.yml |
Pins the main test reusable workflow ref. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| jobs: | ||
| test: | ||
| uses: SiaFoundation/workflows/.github/workflows/go-test.yml@master | ||
| uses: SiaFoundation/workflows/.github/workflows/go-test.yml@22e56c0750c0febb09784caa01c60021e0b5f111 # master |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uses:reference in workflows to a specific commit SHA@v4→ latest v4.x.y SHA) to avoid breaking changesWhy
Mitigates supply-chain attacks where a tag could be retargeted to malicious code. Pinning to a SHA is the recommended hardening practice.
Notes for reviewers
SiaFoundation/workflows@masteranddtolnay/rust-toolchain@stable|nightly(which use a branch ref intentionally), the pin uses the current branch tip SHA — future updates will require a follow-up PR