Fix DEV-740 USB dock reconnect logging handoff#108
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refines the dock/USB handoff gating so that dock state changes are no longer entirely suppressed during sensing. The previous coarse !sensing guard is replaced with a finer-grained predicate (LogAndStream_allowDockComms) that defers only the communication-interface init (DockUart / USB-CDC/MSC) while BT streaming is active; SD routing, dock state tracking and the dock state-change sequence now always proceed. Deferred comms init is expected to be restored later by ShimSens_stopSensing(1) when BT streaming ends.
Changes:
- Drop the
LogAndStream_allowProcessDockChange()gating fromLogAndStream_dockOrUsbStateUpdate()so dock/USB state changes are always processed. - Rename
LogAndStream_allowProcessDockChange()→LogAndStream_allowDockComms()and switch its condition from!sensingto!btStreaming; apply it insideassignSdToUsb(gatesUSB_init) andassignSdToDock(gatesDockUart_init). - Update the corresponding declaration in the header.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| log_and_stream_common.h | Renames the public predicate from allowProcessDockChange to allowDockComms. |
| log_and_stream_common.c | Removes top-level dock-change gate, narrows scope to comms init, and changes condition to !btStreaming. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4 tasks
Agent-Logs-Url: https://github.com/ShimmerResearch/log-and-stream-common/sessions/fc53ef09-3a32-4b4f-b84d-84ad764e8149 Co-authored-by: marknolan <6526073+marknolan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.