DEV-573 Vela IF820 fw v1.04.18.18 support and disable sniff mode#100
Open
marknolan wants to merge 8 commits into
Open
DEV-573 Vela IF820 fw v1.04.18.18 support and disable sniff mode#100marknolan wants to merge 8 commits into
marknolan wants to merge 8 commits into
Conversation
…e_and_disable_sniff_mode
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support-related updates around Bluetooth UART handling (likely for Vela IF820 / CYW20820) and introduces a new connection-state flag.
Changes:
- Add
btFirstConnectionEstablishedstatus bit forSHIMMER3R. - Update BT TX buffer sizing comment and add
ShimBt_triggerNextTransfer()API. - Refactor TX-complete flow and adjust when the next TX chunk is triggered.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
log_and_stream_definitions.h |
Adds a new SHIMMER3R status bit (btFirstConnectionEstablished). |
Comms/shimmer_bt_uart.h |
Updates TX buffer documentation and exports ShimBt_triggerNextTransfer(). |
Comms/shimmer_bt_uart.c |
Refactors TX-complete behavior, adds new transfer trigger helper, and changes TX gating logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2519
to
+2521
| #if defined(SHIMMER3) | ||
| ShimBt_triggerNextTransfer(); | ||
| #endif |
Comment on lines
+2550
to
+2554
| #if defined(SHIMMER3) | ||
| if (!ShimBt_btTxInProgressGet()) | ||
| #else | ||
| if (!ShimBt_btTxInProgressGet() && !isPendingResponseFromBtModule()) | ||
| #endif |
…e_and_disable_sniff_mode
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…e_and_disable_sniff_mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.