Skip to content

feat(config): add base of configuration#24

Merged
Mael-RABOT merged 1 commit intodevfrom
mra/feat-configuration-ui
Mar 28, 2026
Merged

feat(config): add base of configuration#24
Mael-RABOT merged 1 commit intodevfrom
mra/feat-configuration-ui

Conversation

@Mael-RABOT
Copy link
Copy Markdown
Contributor

@Mael-RABOT Mael-RABOT commented Feb 9, 2026

Figma ca m'a saoulé...
image

#Closes Sentience-Robotics/lucy_ros2#69

Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Copy link
Copy Markdown

@Arcod7 Arcod7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worth mentioning the fact hardcoded JointCategory has been removed (from what I understand)

LGTM

Comment thread src/Components/JointCategory.tsx
Comment thread src/Pages/NotFound.tsx
Comment thread src/Pages/Configuration.tsx
@charlesmadjeri
Copy link
Copy Markdown
Contributor

charlesmadjeri commented Feb 9, 2026

Comment transfered on the issue page for discussion Sentience-Robotics/lucy_ros2#69

Copy link
Copy Markdown
Contributor

@charlesmadjeri charlesmadjeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refacto !
It makes me think about these 2 refacto subjects that we can maybe apply in this PR:

  • left/right arm switch should be removed as it will be replaced by board/pin mapping config
  • Apparently we can remove the field to enter the ros bridge url as it is auto-detected by ros-bridge something like that ? @Arcod7 can you remeber why and if it is still the case ?

@Arcod7
Copy link
Copy Markdown

Arcod7 commented Feb 10, 2026

  • Apparently we can remove the field to enter the ros bridge url as it is auto-detected by ros-bridge something like that ? @Arcod7 can you remeber why and if it is still the case ?

For me it's still the case so that we keep the control to debug or change the ROS url manually if needed.
But we could hide this in some settings because a simple user would not need to change that (the url).
Today we still use the button to create the connection but it could easily be automated behind the scenes, I don't see a case where we would like to connect to the web interface without connecting to the ROS bridge.
If we remove the button, we still need a way to log the ros bridge connection state.

@Mael-RABOT
Copy link
Copy Markdown
Contributor Author

Finalement y'a un figma

@Mael-RABOT Mael-RABOT merged commit 240f3f2 into dev Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants