Skip to content

[AMD] Qwen3.5-FP8 MI355X SGLang disagg perf tuning: Docker image update / Qwen3.5-FP8 MI355X SGLang disagg 性能调优 更新Docker image#2094

Merged
adibarra merged 5 commits into
mainfrom
chang/qwen3.5-mi355-di-perf-tuning-rebased
Jul 17, 2026
Merged

[AMD] Qwen3.5-FP8 MI355X SGLang disagg perf tuning: Docker image update / Qwen3.5-FP8 MI355X SGLang disagg 性能调优 更新Docker image#2094
adibarra merged 5 commits into
mainfrom
chang/qwen3.5-mi355-di-perf-tuning-rebased

Conversation

@ChangLiu0709

@ChangLiu0709 ChangLiu0709 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Changes

  • Docker image bump: update qwen3.5-fp8-mi355x-sglang-disagg image from lmsysorg/sglang-rocm:v0.5.11-rocm700-mi35x-20260511 to lmsysorg/sglang:v0.5.14-rocm720-mi35x (ROCm 7.0 → 7.2, sglang v0.5.11 → v0.5.14).
  • Concurrency sweep: 1K1K and 8K1K both set to [ 8, 16, 32, 64, 128 ].

Authors

@ChangLiu0709
@chunfangamd

中文说明

Qwen3.5-FP8 MI355X SGLang 分离式推理性能调优:

  • 升级 Docker 镜像至 lmsysorg/sglang:v0.5.14-rocm720-mi35x(ROCm 7.0 → 7.2,sglang v0.5.11 → v0.5.14)。
  • 并发扫描:1K1K 和 8K1K 均设为 [ 8, 16, 32, 64, 128 ]

Made with Cursor

…pool, concurrency sweep

- Bump image from sglang-rocm:v0.5.11-rocm700 to sglang:v0.5.14-rocm720
- Add mia1-p01-g09 to disagg SLURM exclude list (broken pyxis)
- Expand mi355x-disagg runner pool from 3 to 9 nodes
- Set 1K1K and 8K1K concurrency to [ 8, 16, 32, 64, 128 ]

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-fail-fast label (strongly recommended) to this PR — the benchmark sweep only runs on labeled PRs. Use full-sweep-enabled only if you need matrix jobs to keep running past a failure.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-fail-fast 标签(强烈推荐)— 基准测试 sweep 仅在带有标签的 PR 上运行。仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

@ChangLiu0709
ChangLiu0709 marked this pull request as ready for review July 6, 2026 13:37
@ChangLiu0709
ChangLiu0709 requested a review from a team July 6, 2026 13:37
@claude

claude Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Claude finished @ChangLiu0709's task in 1m 52s —— View job


PR Review

  • Gather context and read the PR diff (git diff origin/main...HEAD)
  • Validate master config + perf-changelog.yaml pairing and entry position
  • Validate container image accessibility and runner pool changes
  • Post review feedback

Summary

One 🟡 warning, no blocking issues. The changelog entry's pr-link points to #2092, the closed pre-rebase predecessor, instead of this PR (#2094) — see the inline comment with a one-line suggestion.

Everything else checks out:

  • configs/amd-master.yaml was modified and perf-changelog.yaml was updated in the same PR, with the new entry correctly appended at the end of the file.
  • New image lmsysorg/sglang:v0.5.14-rocm720-mi35x is a public Docker Hub reference (valid format). I could not externally verify the tag exists from this environment (no network fetch permission), but the full-sweep-enabled label means CI will fail fast on a bad tag.
  • configs/runners.yaml: the six new nodes are added under the correct mi355x-disagg label, matching the changelog's "3 to 9 nodes" claim.
  • submit.sh: adding mia1-p01-g09 to the default SLURM exclude list is consistent with the changelog note about broken pyxis on that node.
  • Concurrency sweep trims ([8, 16, 32, 64, 128] for both 1K1K and 8K1K) match the PR description.

Co-authored-by: Cursor <cursoragent@cursor.com>
@ChangLiu0709
ChangLiu0709 force-pushed the chang/qwen3.5-mi355-di-perf-tuning-rebased branch from 9c4b981 to f557d68 Compare July 6, 2026 13:38
Comment thread perf-changelog.yaml Outdated
@github-actions

This comment was marked as outdated.

Comment thread perf-changelog.yaml Outdated
@github-actions

This comment was marked as outdated.

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

@1am9trash

Copy link
Copy Markdown
Collaborator

/reuse-sweep-run

@1am9trash

Copy link
Copy Markdown
Collaborator

Hi, @ChangLiu0709
Do we have a cookbook PR for Qwen3.5 disagg? It seems there are not disaggregation args on cookbook website.
Feel free to correct if I am wrong.

@github-actions

This comment was marked as outdated.

@ChangLiu0709

Copy link
Copy Markdown
Collaborator Author

Hi, @ChangLiu0709 Do we have a cookbook PR for Qwen3.5 disagg? It seems there are not disaggregation args on cookbook website. Feel free to correct if I am wrong.

Hi @1am9trash can sync up to SGLang cookbook soon.

@ChangLiu0709

Copy link
Copy Markdown
Collaborator Author

Hi @1am9trash, PR to sglang cookbook created: sgl-project/sglang#31454.

@ChangLiu0709

ChangLiu0709 commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator Author

Hi @1am9trash, PR to sglang cookbook got merged: sgl-project/sglang#31454. Wondering if we can have this PR merged as well : )

@1am9trash 1am9trash left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a PR reviewer and CODEOWNER, I have reviewed this and have:

  • Verified that as of the moment of typing this, this is the latest version of PR_REVIEW_CHECKLIST.md
  • Verified that the general code quality meets the InferenceX standard and does not make the code quality any worse.
  • Verified that this PR has passed PR validation. Please link to GitHub Action workflow that shows this. Link: https://github.com/SemiAnalysisAI/InferenceX/actions/runs/28795797050?pr=2094
  • Verified that this PR passes evals. Please link to GitHub Action workflow that shows this. Link: https://github.com/SemiAnalysisAI/InferenceX/actions/runs/28795797050?pr=2094
  • Verified that speculative decoding PRs uses chat templates to align the AL distribution to real world
  • For agentic workloads: verified that speculative-decoding configs (EAGLE / MTP / draft models) run with simulated synthetic acceptance, with the acceptance-length value taken from the committed golden AL curve in golden_al_distribution/ for that model, thinking mode, and draft length. A submission may choose any supported draft length, but it may not substitute a different acceptance target.
  • Verified that the model architecture isn't changed with benchmark hacks like using --hf-overrides to skipping indexer for every x layers on models that don't natively support this. As a general rule, we won't accept optimizations that reduces the number of model architecture FLOPs. Anything that makes that same computation run faster is fair game; FLOPs at lower precisions is fine, given that the config passes private evals. As an general north star princple, we should only use optimizations which is used in production by customers that care about accuracy
  • If an company claims that they support vLLM/SGLang as first class LLM inference engines on their hardware, I have verified that the respective vLLM submission made using upstream https://hub.docker.com/u/vllm docker repo, upstream SGLang https://hub.docker.com/u/lmsysorg docker repo. The only exceptions are for new hardware, such as MI455X UALoE72, Vera Rubin NVL72, Rubin NVL8, etc., and for new model architectures where there is an actual reason why vLLM/SGLang does not fundamentally support them yet as supported by vLLM/SGLang community maintainers
  • If an company claims that they support vLLM/SGLang as first class upstream in-tree LLM inference engines on their hardware, I have have verified that the respective vLLM/SGLang submission has been made before additional frameworks (TRT-LLM, ATOM, etc.). The only exceptions are for new hardware, such as MI455X UALoE72, Vera Rubin NVL72, Rubin NVL8, etc., and for new model architectures where there is an actual reason why vLLM/SGLang does not fundamentally support them yet.
  • Verified that every single-node vLLM/SGLang recipe in this PR is documented in the official vLLM recipes and/or the SGLang cookbook:
    • I linked the corresponding upstream PR in the vLLM recipe repo or SGLang repo and verified that it is MERGED before this InferenceX PR merges. An opened, draft, or closed-without-merge upstream PR does not satisfy this requirement. If the matching recipe was already published, I linked the published recipe/cookbook page in the additional detail section below.
  • Verified that this PR does not patch the inference engine or serving stack — the pinned image must run as shipped. This covers .patch files / git apply / patch, inline patches embedded in benchmark scripts (e.g. a python3/sed heredoc that rewrites installed engine sources before serving), in-place edits of site-packages, monkey-patching, overwriting container files, and installing forked/rebuilt engine wheels on top of the pinned image. The only exception is a patch covered by a filled-out waiver at docs/waiver/<PR_NUMBER>.md — named after the PR that introduces the patch and filed in that same PR, stating what is patched, why the unmodified upstream image cannot run this benchmark, the upstream PR/issue link, and the removal plan — which I have linked below in the additional detail section.
  • If any of the above criteria cannot reasonably be satisfied, I have provided additional reasoning below.

Additional detail section:

Signed: @1am9trash

@Klaud-Cold

Copy link
Copy Markdown
Collaborator

✅✅✅ Verdict: PASS ✅✅✅

✅ Check 0 (CODEOWNER): PASS — @1am9trash is a named owner of configs/amd-master.yaml; configs/runners.yaml / perf-changelog.yaml fall to the catch-all, covered by any recognized CODEOWNER.
✅ Check 1 (passing sweep on in-PR commit): PASS — commit f557d684 (in this PR) has green executed multi-node 1k1k /, multi-node 8k1k /, and multi-node eval / jobs on run 28795797050; single-node lanes are skipped by design for this disagg-only PR.
✅ Check 2 (evals pass): PASS — GSM8K em_strict 0.9757 (n=1319) vs qwen3.5 threshold 0.94 (utils/evals/thresholds.yaml), run used this PR's image lmsysorg/sglang:v0.5.14-rocm720-mi35x.
➖ Check 3 (recipe link): N/A — disaggregated/multi-node submission (multinode: true, disagg: true); the recipe-link requirement applies to single-node recipes only. (Informational: linked cookbook PR sgl-project/sglang#31454 is MERGED 2026-07-16.)
✅ Check 4 (reuse command): PASS — bare /reuse-sweep-run posted by @1am9trash (COLLABORATOR).
✅ Check 5 (latest checklist): PASS — sign-off matches the current docs/PR_REVIEW_CHECKLIST.md template with all items checked.
✅ Check 6 (upstream image / engine-first): PASS — lmsysorg/sglang:v0.5.14-rocm720-mi35x is from the upstream lmsysorg org; no non-vLLM/SGLang framework entry added.
✅ Check 7 (no architecture hacks): PASS — diff is an image bump, conc-list trim, and runner-pool expansion; no server args or model overrides touched.
➖ Check 8 (spec-decode chat template): N/A — changed lanes are spec-decoding: "none"; no spec-decode changes.
✅ Check 9 (no engine patches): PASS — no benchmark scripts touched; no patching introduced.
➖ Check 10 (agentic golden AL): N/A — no agentic speculative-decoding changes.

@adibarra
adibarra merged commit 2b67e81 into main Jul 17, 2026
30 checks passed
@adibarra
adibarra deleted the chang/qwen3.5-mi355-di-perf-tuning-rebased branch July 17, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants