Skip to content

[Education] Normalize adapter naming metadata#7

Draft
SeCuReDmE-main-dev wants to merge 2 commits into
mainfrom
agent/education-name-pattern-v1
Draft

[Education] Normalize adapter naming metadata#7
SeCuReDmE-main-dev wants to merge 2 commits into
mainfrom
agent/education-name-pattern-v1

Conversation

@SeCuReDmE-main-dev

Copy link
Copy Markdown
Owner

Summary

  • Adds the SecuredMe Education canonical app route to the Codex and Antigravity adapter maps.
  • Adds an explicit naming block with the name-pattern policy, canonical slug, display name, repository name, public route, canonical domain, and legacy alias.
  • Keeps existing adapter IDs, domain, status, and pre-alpha boundary intact.

Validation

  • JSON edited through GitHub contents API.
  • No runtime tests run in this environment.

Notes

This is metadata-only. It does not rename the repository or change runtime code.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the adapter map configuration files for both antigravity and codex platforms by adding a canonical route and introducing a new naming block with normalized metadata. The review feedback points out significant redundancy between the newly added naming block and the existing app block, which could lead to configuration drift, and suggests consolidating these blocks or deprecating the redundant fields.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +12 to +27
"naming": {
"policy": "securedme.education.name-pattern.v1",
"suite": "SecuredMe Education",
"canonical_slug": "ffed-qlc",
"display_name": "FfeD-QLC",
"repository_name": "FfeD-QLC-MVP",
"repository_full_name": "SeCuReDmE-main-dev/FfeD-QLC-MVP",
"adapter_prefix": "securedme-ffed-qlc",
"codex_adapter": "securedme-ffed-qlc-codex-adapter",
"antigravity_adapter": "securedme-ffed-qlc-antigravity-adapter",
"public_route": "https://securedme.ca/education/apps/ffed-qlc/",
"canonical_domain": "ffed-qlc.securedme.ca",
"legacy_or_internal_names": [
"FfeD-QLC-MVP"
]
},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The newly added naming block introduces significant redundancy with the existing app block:

  • canonical_slug (line 15) duplicates slug (line 5)
  • display_name (line 16) duplicates name (line 6)
  • repository_name (line 17) duplicates path (line 7)
  • public_route (line 22) duplicates canonical_route (line 9)
  • canonical_domain (line 23) duplicates canonical_domain (line 8)

This duplication increases the risk of configuration drift. If the schema allows, consider consolidating these blocks or deprecating the redundant fields in the app block to maintain a single source of truth.

Comment on lines +12 to +27
"naming": {
"policy": "securedme.education.name-pattern.v1",
"suite": "SecuredMe Education",
"canonical_slug": "ffed-qlc",
"display_name": "FfeD-QLC",
"repository_name": "FfeD-QLC-MVP",
"repository_full_name": "SeCuReDmE-main-dev/FfeD-QLC-MVP",
"adapter_prefix": "securedme-ffed-qlc",
"codex_adapter": "securedme-ffed-qlc-codex-adapter",
"antigravity_adapter": "securedme-ffed-qlc-antigravity-adapter",
"public_route": "https://securedme.ca/education/apps/ffed-qlc/",
"canonical_domain": "ffed-qlc.securedme.ca",
"legacy_or_internal_names": [
"FfeD-QLC-MVP"
]
},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The newly added naming block introduces significant redundancy with the existing app block:

  • canonical_slug (line 15) duplicates slug (line 5)
  • display_name (line 16) duplicates name (line 6)
  • repository_name (line 17) duplicates path (line 7)
  • public_route (line 22) duplicates canonical_route (line 9)
  • canonical_domain (line 23) duplicates canonical_domain (line 8)

This duplication increases the risk of configuration drift. If the schema allows, consider consolidating these blocks or deprecating the redundant fields in the app block to maintain a single source of truth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant