fix(sentry): don't report settings-save input validation as errors

[vpetersson]

Issues Fixed

Sentry ANTHIAS-3D (AuthSettingsError: New passwords do not match!, culprit /settings/save/).

Description

AuthSettingsError is operator input validation from the settings-save flow — a mismatched or incorrect password, a username already taken, or a password that fails the strength validators. It is not a bug: the message is already shown to the operator and the next attempt self-corrects.

Both settings-save surfaces (the HTML view and the DRF v2 view) caught it under a broad except Exception followed by logger.exception(...). Sentry's logging integration turns that ERROR-level record into an event, so an operator typo pages us.

This fixes it at the source and adds a backstop:

• Catch AuthSettingsError ahead of the generic handler in both settings_save (HTML) and DeviceSettingsViewV2.patch (DRF). Log it at warning (no traceback) instead of logger.exception — a WARNING record never becomes a Sentry event. The DRF view now also echoes the operator-friendly message instead of burying it under a generic "An error occurred while saving settings."
• Add AuthSettingsError to the before_send drop filter as a backstop for any other code path that might log it as an error — this is the "ignore for similar things" net.
• Spell auth.py's AnyRequest as an explicit TypeAlias. The implicit AnyRequest = HttpRequest | DRFRequest form flipped to mypy Variable … is not valid as a type once settings.py started importing the module for the filter; the explicit alias resolves the forward-ref robustly regardless of import order.
• Regression tests for the before_send drop and for the warning-level, no-traceback v2 rejection (asserts 400 + the specific message, nothing persisted, and no ERROR/exc_info record).

This mirrors the same "expected transient/expected state, not a bug" treatment the before_send filter already gives redis blips and client disconnects.

Checklist

• I have performed a self-review of my own code.
• New and existing unit tests pass locally and on CI with my changes.
• I have done an end-to-end test for Raspberry Pi devices.
• I have tested my changes for x86 devices.
• I added a documentation for the changes I have made (when necessary).

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

This PR reduces Sentry noise by treating AuthSettingsError from the settings-save flow as expected operator input validation (e.g., password mismatch, weak password, username taken) rather than a server error, while preserving operator-facing feedback and adding regression coverage.

Changes:

• Catch AuthSettingsError explicitly in both the HTML settings save view and the v2 DRF PATCH endpoint, logging at WARNING (no traceback) and returning/printing the operator-friendly message.
• Add AuthSettingsError to Sentry’s _sentry_before_send drop filter as a backstop.
• Add regression tests verifying the before_send drop and that the v2 endpoint logs validation failures at WARNING without exc_info and persists nothing.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/test_sentry.py	Adds coverage ensuring Sentry drops AuthSettingsError events via before_send.
src/anthias_server/lib/auth.py	Refines typing for AnyRequest via explicit TypeAlias to keep mypy stable when imported from settings.
src/anthias_server/django_project/settings.py	Drops AuthSettingsError in _sentry_before_send (lazy import) to prevent operator validation from becoming Sentry events.
src/anthias_server/app/views.py	Handles AuthSettingsError separately in settings_save, logs WARNING, and shows operator-friendly message.
src/anthias_server/api/views/v2.py	Handles AuthSettingsError separately in device settings PATCH, logs WARNING, and returns 400 with the specific message.
src/anthias_server/api/tests/test_v2_endpoints.py	Adds regression test asserting 400 + message, no persistence, and no ERROR/exc_info logging for password mismatch.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.