Fix pinned Linux miner artifact hash#5634
Conversation
Signed-off-by: minyanyi <109479933+minyanyi@users.noreply.github.com>
github-actions
Bot
added
BCOS-L1
|
CI note: the broad Focused validation for this PR passes locally:
|
kekehanshujun
left a comment
kekehanshujun
left a comment
There was a problem hiding this comment.
Approved current head 0f2d9c716bdcdfadf4f574241d1276305f56ac2f.
This PR is a focused pin update: setup_miner.py now pins the Linux artifact to the SHA-256 of the checked-in miners/linux/rustchain_linux_miner.py contents. That keeps the installer verification path strict while avoiding false rejection of the current raw GitHub artifact.
Validation I ran locally after applying the PR hunk to a RustChain worktree:
python -B -m pytest -q tests/test_setup_miner_downloads.py --tb=short -p no:cacheprovider
# 2 passed
python -B -m py_compile setup_miner.py tests/test_setup_miner_downloads.py
# passed
git diff --check -- setup_miner.py
# passed
sha256(miners/linux/rustchain_linux_miner.py)
# 91815ecf25042cfea1c60817c8b6e701c4324b60ceeb433da068243920344c0a
I also checked the PR's red broad CI note: the failing test job is still blocked during collection by unrelated base dependency gaps before this focused setup-miner test is reached. I do not see a blocker in this PR.
jaxint
left a comment
jaxint
left a comment
There was a problem hiding this comment.
LGTM! Great work on this PR. 🚀
5 participants
Summary
setup_miner.pyminers/linux/rustchain_linux_miner.pycontents onmainWhy
tests/test_setup_miner_downloads.pycurrently fails becausesetup_miner.MINER_ARTIFACTS["Linux"]["sha256"]still points at an older file hash (9475fe...), while the checked-in Linux miner hashes to91815e.... That mismatch also means Linux setup would reject the current raw GitHub miner artifact during SHA verification.Validation
python -B -m pytest -q tests/test_setup_miner_downloads.py --tb=short -p no:cacheprovider-> 2 passedpython -B -m py_compile setup_miner.py tests/test_setup_miner_downloads.pygit diff --check