docs: fix Manticore security tool link#5589
Conversation
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
ZacharyZhang-NY
left a comment
There was a problem hiding this comment.
Approved PR #5589 at head 9bbdb7b.
This is a focused documentation link repair in the ERC20 security considerations guide. The old crytic/manticore repository URL is retired and returns 404, while the replacement trailofbits/manticore URL resolves successfully. The surrounding security tooling list remains unchanged.
Validation run:
curl.exe -L -s -o NUL -w "old=%{http_code} %{url_effective}\n" --max-time 12 https://github.com/crytic/manticore->old=404 https://github.com/crytic/manticorecurl.exe -L -s -o NUL -w "new=%{http_code} %{url_effective}\n" --max-time 12 https://github.com/trailofbits/manticore->new=200 https://github.com/trailofbits/manticoregit diff --check origin/main...HEAD -- contracts/erc20/docs/SECURITY_CONSIDERATIONS.md-> passedpython3 tools/bcos_spdx_check.py --base-ref origin/main-> BCOS SPDX check: OK
I found no blocker in this scoped documentation fix.
TJCurnutte
left a comment
There was a problem hiding this comment.
Approved. This is a small docs-only correction, and the source check lines up with the current GitHub repository location.
Validation performed at head 9bbdb7bfabcb1e52c366934f860d1dff0318c061:
git diff --check origin/main...HEAD -- contracts/erc20/docs/SECURITY_CONSIDERATIONS.md
python3 - <<'PY'
from pathlib import Path
text = Path('contracts/erc20/docs/SECURITY_CONSIDERATIONS.md').read_text()
print('old_present=', 'github.com/crytic/manticore' in text)
print('new_present=', 'github.com/trailofbits/manticore' in text)
PY
gh api --method GET repos/trailofbits/manticore --jq '{full_name,html_url,archived,disabled,description}'
gh api --method GET repos/crytic/manticoreProof:
git diff --checkpassed for the changed markdown file.- The Manticore line now points to
https://github.com/trailofbits/manticore; the stalehttps://github.com/crytic/manticorestring is absent. - GitHub API resolves
trailofbits/manticoreas an active, non-disabled repository (archived: false,disabled: false). - The old
crytic/manticorerepository probe returns404 Not Found.
That makes the security-tool reference accurate without changing surrounding guidance.
minyanyi
left a comment
There was a problem hiding this comment.
Approved. I verified the link change directly:
https://github.com/crytic/manticorereturns 404 / repository not found.https://github.com/trailofbits/manticoreresolves with HTTP 200 and the GitHub API confirms the repository exists and is not archived.
The PR is a scoped one-line docs fix in contracts/erc20/docs/SECURITY_CONSIDERATIONS.md and does not affect code paths or generated artifacts.
jaxint
left a comment
There was a problem hiding this comment.
LGTM! Great work on this PR. 🚀
kekehanshujun
left a comment
There was a problem hiding this comment.
I verified the replacement Manticore repository link resolves to trailofbits/manticore, and the change is scoped to the security tooling reference in the ERC-20 docs. I do not see a blocker.
Summary
crytic/manticorepath to the livetrailofbits/manticorerepositoryValidation
curl -L -s -o /dev/null -w "old=%{http_code} %{url_effective}\n" --max-time 12 https://github.com/crytic/manticore->old=404 https://github.com/crytic/manticorecurl -L -s -o /dev/null -w "new=%{http_code} %{url_effective}\n" --max-time 12 https://github.com/trailofbits/manticore->new=200 https://github.com/trailofbits/manticoregit diff --check -- contracts/erc20/docs/SECURITY_CONSIDERATIONS.md