Skip to content

docs: fix Manticore security tool link#5589

Merged
Scottcjn merged 1 commit into
Scottcjn:mainfrom
iamdinhthuan:fix-manticore-security-link
May 18, 2026
Merged

docs: fix Manticore security tool link#5589
Scottcjn merged 1 commit into
Scottcjn:mainfrom
iamdinhthuan:fix-manticore-security-link

Conversation

@iamdinhthuan
Copy link
Copy Markdown

Summary

  • update the ERC20 security considerations Manticore link from the retired crytic/manticore path to the live trailofbits/manticore repository

Validation

  • curl -L -s -o /dev/null -w "old=%{http_code} %{url_effective}\n" --max-time 12 https://github.com/crytic/manticore -> old=404 https://github.com/crytic/manticore
  • curl -L -s -o /dev/null -w "new=%{http_code} %{url_effective}\n" --max-time 12 https://github.com/trailofbits/manticore -> new=200 https://github.com/trailofbits/manticore
  • git diff --check -- contracts/erc20/docs/SECURITY_CONSIDERATIONS.md

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label May 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Welcome to RustChain! Thanks for your first pull request.

Before we review, please make sure:

  • Non-doc PRs have a BCOS-L1 or BCOS-L2 label
  • Doc-only PRs are exempt from BCOS tier labels when they only touch docs/**, *.md, or common image/PDF files
  • New code files include an SPDX license header
  • You've tested your changes against the live node

Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150)

A maintainer will review your PR soon. Thanks for contributing!

Copy link
Copy Markdown

@ZacharyZhang-NY ZacharyZhang-NY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved PR #5589 at head 9bbdb7b.

This is a focused documentation link repair in the ERC20 security considerations guide. The old crytic/manticore repository URL is retired and returns 404, while the replacement trailofbits/manticore URL resolves successfully. The surrounding security tooling list remains unchanged.

Validation run:

  • curl.exe -L -s -o NUL -w "old=%{http_code} %{url_effective}\n" --max-time 12 https://github.com/crytic/manticore -> old=404 https://github.com/crytic/manticore
  • curl.exe -L -s -o NUL -w "new=%{http_code} %{url_effective}\n" --max-time 12 https://github.com/trailofbits/manticore -> new=200 https://github.com/trailofbits/manticore
  • git diff --check origin/main...HEAD -- contracts/erc20/docs/SECURITY_CONSIDERATIONS.md -> passed
  • python3 tools/bcos_spdx_check.py --base-ref origin/main -> BCOS SPDX check: OK

I found no blocker in this scoped documentation fix.

Copy link
Copy Markdown

@TJCurnutte TJCurnutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. This is a small docs-only correction, and the source check lines up with the current GitHub repository location.

Validation performed at head 9bbdb7bfabcb1e52c366934f860d1dff0318c061:

git diff --check origin/main...HEAD -- contracts/erc20/docs/SECURITY_CONSIDERATIONS.md
python3 - <<'PY'
from pathlib import Path
text = Path('contracts/erc20/docs/SECURITY_CONSIDERATIONS.md').read_text()
print('old_present=', 'github.com/crytic/manticore' in text)
print('new_present=', 'github.com/trailofbits/manticore' in text)
PY
gh api --method GET repos/trailofbits/manticore --jq '{full_name,html_url,archived,disabled,description}'
gh api --method GET repos/crytic/manticore

Proof:

  • git diff --check passed for the changed markdown file.
  • The Manticore line now points to https://github.com/trailofbits/manticore; the stale https://github.com/crytic/manticore string is absent.
  • GitHub API resolves trailofbits/manticore as an active, non-disabled repository (archived: false, disabled: false).
  • The old crytic/manticore repository probe returns 404 Not Found.

That makes the security-tool reference accurate without changing surrounding guidance.

Copy link
Copy Markdown
Contributor

@minyanyi minyanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I verified the link change directly:

  • https://github.com/crytic/manticore returns 404 / repository not found.
  • https://github.com/trailofbits/manticore resolves with HTTP 200 and the GitHub API confirms the repository exists and is not archived.

The PR is a scoped one-line docs fix in contracts/erc20/docs/SECURITY_CONSIDERATIONS.md and does not affect code paths or generated artifacts.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work on this PR. 🚀

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@kekehanshujun kekehanshujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the replacement Manticore repository link resolves to trailofbits/manticore, and the change is scoped to the security tooling reference in the ERC-20 docs. I do not see a blocker.

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Scottcjn Scottcjn merged commit 9c6da03 into Scottcjn:main May 18, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/XS PR: 1-10 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants