Skip to content

docs: fix Legend of Elya reference link#5584

Merged
Scottcjn merged 2 commits into
Scottcjn:mainfrom
iamdinhthuan:docs-fix-console-legend-link
May 18, 2026
Merged

docs: fix Legend of Elya reference link#5584
Scottcjn merged 2 commits into
Scottcjn:mainfrom
iamdinhthuan:docs-fix-console-legend-link

Conversation

@iamdinhthuan
Copy link
Copy Markdown

Summary

  • Replace the dead Legend of Elya reference in docs/CONSOLE_MINING_SETUP.md with the current Scottcjn/legend-of-elya-n64 repository URL.
  • Keep the docs-only change scoped to the References list.

Bounty context: Scottcjn/rustchain-bounties#444
Wallet/miner ID: iamdinhthuan

Validation

  • curl -sS -L -o /dev/null -w "%{http_code} %{url_effective}\n" https://github.com/ilya-kh/legend-of-elya -> 404 https://github.com/ilya-kh/legend-of-elya
  • curl -sS -L -o /dev/null -w "%{http_code} %{url_effective}\n" https://github.com/Scottcjn/legend-of-elya-n64 -> 200 https://github.com/Scottcjn/legend-of-elya-n64
  • git diff --check -- docs/CONSOLE_MINING_SETUP.md

Duplicate check

@github-actions
Copy link
Copy Markdown
Contributor

Welcome to RustChain! Thanks for your first pull request.

Before we review, please make sure:

  • Non-doc PRs have a BCOS-L1 or BCOS-L2 label
  • Doc-only PRs are exempt from BCOS tier labels when they only touch docs/**, *.md, or common image/PDF files
  • New code files include an SPDX license header
  • You've tested your changes against the live node

Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150)

A maintainer will review your PR soon. Thanks for contributing!

@github-actions github-actions Bot added documentation Improvements or additions to documentation size/XS PR: 1-10 lines labels May 17, 2026
Copy link
Copy Markdown

@ZacharyZhang-NY ZacharyZhang-NY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved PR #5584 at head 3cd20e8.

This is a focused docs-only link repair in docs/CONSOLE_MINING_SETUP.md. The old Legend of Elya reference returns 404, and the replacement repository URL resolves successfully. The change is scoped to the References list and preserves the surrounding console-mining documentation.

Validation run:

  • git diff --check origin/main...HEAD -- docs/CONSOLE_MINING_SETUP.md -> passed
  • curl.exe -sS -L -o NUL -w "%{http_code} %{url_effective}\n" https://github.com/ilya-kh/legend-of-elya -> 404 https://github.com/ilya-kh/legend-of-elya
  • curl.exe -sS -L -o NUL -w "%{http_code} %{url_effective}\n" https://github.com/Scottcjn/legend-of-elya-n64 -> 200 https://github.com/Scottcjn/legend-of-elya-n64

I did not find a blocking issue in this focused documentation fix.

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iamdinhthuan
Copy link
Copy Markdown
Author

Follow-up pushed in e210c4f2da396af885dcb4142969eb4d468a3d61 to cover the second stale Legend of Elya reference in IMPLEMENTATION_SUMMARY.md instead of opening a duplicate PR.

Current scoped validation:

curl -sS -L -o /dev/null -w "old %{http_code} %{url_effective}\n" https://github.com/ilya-kh/legend-of-elya
# old 404 https://github.com/ilya-kh/legend-of-elya

curl -sS -L -o /dev/null -w "new %{http_code} %{url_effective}\n" https://github.com/Scottcjn/legend-of-elya-n64
# new 200 https://github.com/Scottcjn/legend-of-elya-n64

git diff --check origin/main...HEAD -- docs/CONSOLE_MINING_SETUP.md IMPLEMENTATION_SUMMARY.md
# passed

python3 tools/bcos_spdx_check.py --base-ref origin/main
# BCOS SPDX check: OK

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work on this PR. 🚀

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@kekehanshujun kekehanshujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the replacement Legend of Elya repository exists at Scottcjn/legend-of-elya-n64, and the PR updates both documentation references that pointed at the old repo. I do not see a blocker in this docs fix.

Copy link
Copy Markdown

@TJCurnutte TJCurnutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. This docs-only link repair is small but correct.

Validation run at head e210c4f2da396af885dcb4142969eb4d468a3d61:

  • git diff --check origin/main...HEAD -- IMPLEMENTATION_SUMMARY.md docs/CONSOLE_MINING_SETUP.md
  • Source check confirmed both docs now contain https://github.com/Scottcjn/legend-of-elya-n64 and no longer contain https://github.com/ilya-kh/legend-of-elya.
  • Live GitHub lookup resolved Scottcjn/legend-of-elya-n64 as a public, non-archived repo on default branch main.
  • Live GitHub lookup for the old ilya-kh/legend-of-elya target failed with repository-not-found.

Both console-mining references now point at the existing N64 Legend of Elya source instead of a dead external repo link.

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@HCIE2054 HCIE2054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Scottcjn Scottcjn merged commit d4fce69 into Scottcjn:main May 18, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/XS PR: 1-10 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants