docs: fix Legend of Elya reference link#5584
Conversation
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
ZacharyZhang-NY
left a comment
There was a problem hiding this comment.
Approved PR #5584 at head 3cd20e8.
This is a focused docs-only link repair in docs/CONSOLE_MINING_SETUP.md. The old Legend of Elya reference returns 404, and the replacement repository URL resolves successfully. The change is scoped to the References list and preserves the surrounding console-mining documentation.
Validation run:
git diff --check origin/main...HEAD -- docs/CONSOLE_MINING_SETUP.md-> passedcurl.exe -sS -L -o NUL -w "%{http_code} %{url_effective}\n" https://github.com/ilya-kh/legend-of-elya->404 https://github.com/ilya-kh/legend-of-elyacurl.exe -sS -L -o NUL -w "%{http_code} %{url_effective}\n" https://github.com/Scottcjn/legend-of-elya-n64->200 https://github.com/Scottcjn/legend-of-elya-n64
I did not find a blocking issue in this focused documentation fix.
|
Follow-up pushed in Current scoped validation: |
jaxint
left a comment
There was a problem hiding this comment.
LGTM! Great work on this PR. 🚀
kekehanshujun
left a comment
There was a problem hiding this comment.
I verified the replacement Legend of Elya repository exists at Scottcjn/legend-of-elya-n64, and the PR updates both documentation references that pointed at the old repo. I do not see a blocker in this docs fix.
TJCurnutte
left a comment
There was a problem hiding this comment.
Approved. This docs-only link repair is small but correct.
Validation run at head e210c4f2da396af885dcb4142969eb4d468a3d61:
git diff --check origin/main...HEAD -- IMPLEMENTATION_SUMMARY.md docs/CONSOLE_MINING_SETUP.md- Source check confirmed both docs now contain
https://github.com/Scottcjn/legend-of-elya-n64and no longer containhttps://github.com/ilya-kh/legend-of-elya. - Live GitHub lookup resolved
Scottcjn/legend-of-elya-n64as a public, non-archived repo on default branchmain. - Live GitHub lookup for the old
ilya-kh/legend-of-elyatarget failed with repository-not-found.
Both console-mining references now point at the existing N64 Legend of Elya source instead of a dead external repo link.
Summary
docs/CONSOLE_MINING_SETUP.mdwith the currentScottcjn/legend-of-elya-n64repository URL.Bounty context: Scottcjn/rustchain-bounties#444
Wallet/miner ID:
iamdinhthuanValidation
curl -sS -L -o /dev/null -w "%{http_code} %{url_effective}\n" https://github.com/ilya-kh/legend-of-elya->404 https://github.com/ilya-kh/legend-of-elyacurl -sS -L -o /dev/null -w "%{http_code} %{url_effective}\n" https://github.com/Scottcjn/legend-of-elya-n64->200 https://github.com/Scottcjn/legend-of-elya-n64git diff --check -- docs/CONSOLE_MINING_SETUP.mdDuplicate check
docs/CONSOLE_MINING_SETUP.mdfor other broken links, but I did not find an existing report for theilya-kh/legend-of-elyatarget.