Draft
Conversation
EtienneM
force-pushed
the
feat/512/json_output_2
branch
from
6f51362 to
982c5f6
Compare
EtienneM
force-pushed
the
feat/512/json_output_2
branch
from
982c5f6 to
0e5b2b2
Compare
EtienneM
changed the base branch from
master
to
fix/1147/private_networks_pagination
EtienneM
force-pushed
the
feat/512/json_output_2
branch
from
0e5b2b2 to
c863348
Compare
EtienneM
force-pushed
the
feat/512/json_output_2
branch
from
c863348 to
03ce09c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another implementation compared to the one in #1199. In this one I introduce an generic interface
Renderer. The next step would be to update allcmd/*functions to take a renderer as argument and move the rendering in theinternal/boundaries/out/renderer/tablepackage.Related to #512