Skip to content

fix: stop printing MCP root tokens#138

Merged
matt-dean-git merged 1 commit into
mainfrom
fix/mcp-root-token-log-leak
Jun 5, 2026
Merged

fix: stop printing MCP root tokens#138
matt-dean-git merged 1 commit into
mainfrom
fix/mcp-root-token-log-leak

Conversation

@matt-dean-git
Copy link
Copy Markdown
Collaborator

Summary

  • stop printing raw MCP ROOT_TOKEN values to stderr during auto-mint/reuse startup
  • keep Proxy.RootToken() behavior intact for programmatic access
  • keep non-secret TOKEN_ID operator output
  • update config docs to clarify tokens are not printed
  • add regression tests for auto-minted and supplied root tokens

Test Plan

  • go test ./pkg/mcpserver -run 'TestProxy(AutoMintRoot|ReusedRootToken)DoesNotPrintSecretToken' -count=1 -v
  • go test ./pkg/mcpserver

Operational note

This fixes the source of the SaaS MCP staging startup-log leak. Enterprise should only bump its github.com/satgate-io/satgate dependency after this PR lands; production promotion remains off-limits for the active refactor.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
satgate Ready Ready Preview, Comment Jun 5, 2026 12:03am

@matt-dean-git matt-dean-git merged commit ef4443d into main Jun 5, 2026
5 checks passed
@matt-dean-git matt-dean-git deleted the fix/mcp-root-token-log-leak branch June 5, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant