framestep added, framerate added to mediadetector, playerstate added#69
Open
skaterlui wants to merge 7 commits into
Open
framestep added, framerate added to mediadetector, playerstate added#69skaterlui wants to merge 7 commits into
skaterlui wants to merge 7 commits into
Conversation
Author
|
Finally. I got it. I deleted my repo and forked it once more. Then I commited all changes at once. |
Author
|
@xmedeko Good morning Ondrej, is this pr good for you? Or should I change anything? |
skaterlui
changed the title
Author
|
@xmedeko how about my pr? It would be so nice if you could merge my changes. |
Collaborator
|
@skaterlui The frame step code itself looks good to me. I am just not sure about the player state. IMO the states in this library are not solved well, see also #57. I have no time to investigate the problem more in depth and I am just helping to maintain this lib. This project needs some chief maintainer who will make complex decisions, even break backward compatibility sometimes. So, I can separate and merge just the frame step code, if you are happy with that. |
Merge Mediakit into my own repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added framestep and ratioslider to sample application.