Open
Conversation
Also added more comments, and removed a TODO that needed to be moved to a github question.
| { "5D8D9DE8-29C8-4F01-BDBC-F2D4D7DD6E82", "732 (Hidden Manifest 0374, 5384752978584135997, Hidden Manifest 1483, Hidden Manifest 0028, Hidden Manifest 1278, Hidden Manifest 1591) - client.dll" }, | ||
| { "0A6326B2-F166-487A-A89B-E8930DD16E11", "732 (Hidden Manifest 0603, Hidden Manifest 0476) - client.dll" }, | ||
| { "7F2D929C-03C6-493A-A7D7-AE5428A7C119", "732 (Hidden Manifest 0275, Hidden Manifest 1144) - client.dll" }, | ||
| { "0483C301-20E4-47F3-B4 |
Contributor
Author
There was a problem hiding this comment.
HashSets are supported on .Net Framework 3.5 or greater, but it doesn't seem like there are any version-specific NetFramework flags? Is this proper, given the supported versions are
.NET Core 1.0, Core 1.1, Core 2.0, Core 2.1, Core 2.2, Core 3.0, Core 3.1, 5, 6, 7, 8, 9, 10, 11
.NET Framework 3.5, 4.0, 4.5, 4.5.1, 4.5.2, 4.6, 4.6.1, 4.6.2, 4.7, 4.7.1, 4.7.2, 4.8, 4.8.1
.NET Standard 1.0, 1.1, 1.2, 1.3, 1.4, 1.6, 2.0, 2.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor updates might come in the future with slow/eventual additions, but other than that, this should be done.