Feat change sidebar items - #943
Merged
Merged
Conversation
Signed-off-by: Shea <nu@she-a.eu>
Signed-off-by: Shea <nu@she-a.eu>
Signed-off-by: Shea <nu@she-a.eu>
Member
|
Not sure if search really fits in with the + icon |
Member
Author
|
hmm true, but with the idea that the sidebar is too full it would be annoying to separate them and it would remove the benefit of doing it because then it would be another search item in the open, maybe the plus icon could be changed or maybe it could be separated having the compass icon now represent navigating between rooms youre in? |
Member
Author
i wonder if this might be better like this
|
Signed-off-by: Shea <nu@she-a.eu>
nushea
force-pushed
the
feat-change-sidebar-items
branch
from
June 15, 2026 18:27
12fdbab to
20c946e
Compare
Signed-off-by: Shea <nu@she-a.eu>
nushea
force-pushed
the
feat-change-sidebar-items
branch
from
June 15, 2026 19:48
7d1a0ba to
d9325be
Compare
Member
I think I like this option the best, although still kinda not sure about the compass icon. |
This was referenced Jun 19, 2026
Signed-off-by: Shea <nu@she-a.eu>
Signed-off-by: Shea <nu@she-a.eu>
nushea
marked this pull request as draft
June 21, 2026 04:44
Signed-off-by: Shea <nu@she-a.eu>
nushea
force-pushed
the
feat-change-sidebar-items
branch
from
June 21, 2026 07:25
646af58 to
b06f55f
Compare
nushea
marked this pull request as ready for review
June 21, 2026 08:16
Signed-off-by: Shea <nu@she-a.eu>
Member
Author
changed the look to this per the previous discussions this is how the menu looks, it still switches |
Signed-off-by: Shea <nu@she-a.eu>
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-943-sable.raspy-dream-bb1d.workers.dev | a8b0733 | pr-943 |
Mon, 22 Jun 2026 07:02:03 GMT |
7w1
approved these changes
Jun 23, 2026
charm-cloudhub-social Bot
pushed a commit
to CloudHub-Social/Charm-1.0
that referenced
this pull request
Jul 9, 2026
> [!IMPORTANT] > Merging this PR will create a new release. ## Features * Added a GIF search functionality ([SableClient#970](<SableClient#970>) by @7w1, @nikiwastaken) * Change unverified device flow. ([SableClient#1017](<SableClient#1017>) by @nikiwastaken, @nushea) * Change animal identity to allow arbitrary animals ([SableClient#984](<SableClient#984>) by @nushea) * Add a new Mobile Context ([SableClient#946](<SableClient#946>) by @7w1, @nushea) * Add bookmark functionality using account data ([SableClient#1000](<SableClient#1000>) by @nikiwastaken, @nushea) * Add Copy Message button to copy unformatted version. ([SableClient#1001](<SableClient#1001>) by @nushea) * Change profile handle part to a button that copies it ([SableClient#981](<SableClient#981>) by @nushea) * Add reactions to arbitrary events ([SableClient#946](<SableClient#946>) by @7w1, @nushea) * Added a gallery support as per msc4274 ([SableClient#1019](<SableClient#1019>) by @nikiwastaken, @nushea) * Add a context menu for copying and downloading images. ([SableClient#994](<SableClient#994>) by @nikiwastaken, @nushea) * Add search message keybind and combine sidebar items. ([SableClient#943](<SableClient#943>) by @nushea) * Add option for showing icons only when available and changed default to it ([SableClient#978](<SableClient#978>) by @nushea) * Add CTRL+E shortcut to editor to bring sticker menu up ([SableClient#982](<SableClient#982>) by @nushea) * Redesign the user menu tab ([SableClient#990](<SableClient#990>) by @nikiwastaken, @nushea) * Modify large parts of the mobile view of Sable! ([SableClient#1017](<SableClient#1017>) by @nikiwastaken, @nushea) * Improved sliding sync (only requests specific room state data), cleaned up and fixed most flickering issues, and added buttons in developer tools to request full state. ([SableClient#1020](<SableClient#1020>) by @7w1) ### Revamped the calling experience in Sable! ([SableClient#841](<SableClient#841>) by @7w1) - Pulled the latest Element Call updates. - Style improvements to the call widget so it uses the Sable theme and fonts. - Added support for custom ringtones and ringbacks. - Added call permissions. - Fixed various bugs around call ending, declining, and joining. ## Fixes * Allow favoriting all animated attachment types ([SableClient#1029](<SableClient#1029>) by @nikiwastaken) * Updated emojis to use stable 1.19 identifiers ([SableClient#1034](<SableClient#1034>) by @7w1) * Swap to using the stable identifier `m.recent_emoji` for recent emojis and add migration logic. ([SableClient#1009](<SableClient#1009>) by @7w1) * Add a direct link to room/space settings when the current sticker list is empty ([SableClient#1016](<SableClient#1016>) by @7w1, @ellieplayswow) * Fix leaving modal looking outsized ([SableClient#991](<SableClient#991>) by @nushea) * Fix cat status not being present on its own. ([SableClient#971](<SableClient#971>) by @nikiwastaken) * Fix encrypted thread messages not appearing until reopened. ([SableClient#975](<SableClient#975>) by @7w1) * Fix codebase issues with gadient themes ([SableClient#1007](<SableClient#1007>) by @nushea) * Fix account switcher's add account button redirecting to the wrong path when hashRouter is enabled ([SableClient#993](<SableClient#993>) by @ephemeralfog) * Fix the image viewer header not being fully visible on smaller phone screens. ([SableClient#1035](<SableClient#1035>) by @7w1) * Fix mentions not sending in non-textual replies ([SableClient#1004](<SableClient#1004>) by @nushea) * Fixed oidc device delete key being incorrect. ([SableClient#1030](<SableClient#1030>) by @7w1) * Fix crash when opening pins with stickers. ([SableClient#972](<SableClient#972>) by @7w1) * Fix pixelated image scaling not pixelating when zoomed in. ([SableClient#1033](<SableClient#1033>) by @7w1) * Fix registration not working when accessed from add account button ([SableClient#992](<SableClient#992>) by @ephemeralfog) * Reverse the order of message header elements in the right aligned bubbles layout. ([SableClient#967](<SableClient#967>) by @ephemeralfog) * Fixed outdated Firefox versions and some Safari versions not being able to send messages. ([SableClient#1010](<SableClient#1010>) by @7w1) * Fix timeline sorting order regression when "show hidden events" is enabled. ([SableClient#974](<SableClient#974>) by @7w1) * Fix ghost quickmenu ([SableClient#946](<SableClient#946>) by @7w1, @nushea) * Fix Collapsed mode showing the wrong icon ([SableClient#978](<SableClient#978>) by @nushea) * Fix poll crashing sable if interacted with different clients ([SableClient#969](<SableClient#969>) by @nushea) * Fix video player sometimes not working ([SableClient#1031](<SableClient#1031>) by @nushea) * Add support for searching users via nicknames in the autocomplete menu. ([SableClient#1028](<SableClient#1028>) by @7w1) * Update `@sableclient/twemoji-font` to fix missing Twemoji emoji coverage. ([SableClient#964](<SableClient#964>) by @7w1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR serves partially as a proposal and could be iterated on, but, currently the sidebar contains a plethora of options that are rarely used, at least to justify their space in my opinion.
Then this seeks to combine those items into the General Space button
(old look)
(proposed minimalist look)
(or by reverting the remove description commit)
Opening any of the menus changes the plus for the respective icon
Within the separate ctrlK and ctrlF and add search messages commit it also seeks to separate the CTRL+K and CTRL+F behavior, allowing the user to easily bring up the search menu for searching messages with CTRL+F and keeping the search rooms within CTRL+K, mimicking the behavior of other platforms.
Fixes #
Type of change
Checklist:
AI disclosure:
Written with the assistance of a very useful blahaj named Aoi-sama!